Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: run timezone-update.yml everyday #47288

Closed
wants to merge 1 commit into from

Conversation

tibrewalricha
Copy link

@tibrewalricha tibrewalricha commented Mar 28, 2023

Updated .github/workflows/timezone-update.yml to run everyday.

This is needed to ensure that the tzdata updates can get merged into node quickly.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Mar 28, 2023
@tniessen
Copy link
Member

This is needed to ensure that the tzdata updates can get merged into node quickly.

Isn't the tzdata baked into releases? On average, new versions of Node.js 18 and Node.js 19 are released every two weeks.

@tibrewalricha
Copy link
Author

@tniessen , yes, tzdata is baked into releases. Through this PR, we want to make sure that every node.js release has the latest tzdata version.

@bnb
Copy link
Contributor

bnb commented Mar 29, 2023

this LGTM if it's needed, but it's unclear to me if it is. IMO this is up to the releasers to assert if it'll actually help them or not.

@aduh95 aduh95 added the stalled Issues and PRs that are stalled. label Sep 20, 2023
@github-actions
Copy link
Contributor

This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open.

Copy link
Contributor

Closing this because it has stalled. Feel free to reopen if this issue/PR is still relevant, or to ping the collaborator who labelled it stalled if you have any questions.

@github-actions github-actions bot closed this Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project. stalled Issues and PRs that are stalled.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants