Added links to Changelog for external http_parser/libuv upgrades #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhart
changed the title
|
lgtm but can you fix up your commit message as per CONTRIBUTING.md please? https://github.com/iojs/io.js/blob/v1.x/CONTRIBUTING.md#step-3-commit (i.e. shorter and prefixed with |
rvagg
pushed a commit
that referenced
this pull request
Jan 27, 2015
PR-URL: #471 Reviewed-By: Rod Vagg <[email protected]>
|
fixed the commit msg myself and landed as 8b09ae7, thanks! |
|
Oh cheers, sorry dude, I think I must've missed your comment somehow, my bad. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to see what's actually changed (in case people need to be aware of it).
Alternatives would be linking to the pull requests:
https://github.com/iojs/io.js/pull/397/files
https://github.com/iojs/io.js/pull/423/files
Or, at least in the case of libuv, linking to its Changelog:
https://github.com/libuv/libuv/blob/v1.2.1/ChangeLog