-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta: ask expected behavior reason in bug template #47049
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It happens too often that bug reporters only report _what_ they expect to see without motivating _why_. Having to repeatedly ask for that info gets old.
nodejs-github-bot
added
the
meta
Issues and PRs related to the general management of the project.
label
Mar 12, 2023
MoLow
approved these changes
Mar 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
debadree25
approved these changes
Mar 12, 2023
VoltrexKeyva
approved these changes
Mar 12, 2023
aduh95
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
commit-queue
Add this label to land a pull request using GitHub Actions.
labels
Mar 12, 2023
anonrig
approved these changes
Mar 13, 2023
cjihrig
approved these changes
Mar 13, 2023
RaisinTen
approved these changes
Mar 13, 2023
lpinca
approved these changes
Mar 13, 2023
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Mar 14, 2023
Landed in 4ae7c7a |
targos
pushed a commit
that referenced
this pull request
Mar 18, 2023
It happens too often that bug reporters only report _what_ they expect to see without motivating _why_. Having to repeatedly ask for that info gets old. PR-URL: #47049 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
This was referenced Apr 3, 2023
Merged
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
It happens too often that bug reporters only report _what_ they expect to see without motivating _why_. Having to repeatedly ask for that info gets old. PR-URL: #47049 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
meta
Issues and PRs related to the general management of the project.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It happens too often that bug reporters only report what they expect to see without motivating why. Having to repeatedly ask for that info gets old.