-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: run v8 tests #4704
test: run v8 tests #4704
Changes from 1 commit
09a8050
5a299eb
5be4b9b
f11f3f9
f4ea03f
b1f54db
b27c88f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,6 +11,23 @@ STAGINGSERVER ?= node-www | |
|
||
OSTYPE := $(shell uname -s | tr '[A-Z]' '[a-z]') | ||
|
||
ifdef QUICKCHECK | ||
QUICKCHECK_ARG := --quickcheck | ||
endif | ||
|
||
ifdef ENABLE_V8_TAP | ||
TAP_V8 := --junitout v8-tap.xml | ||
TAP_V8_INTL := --junitout v8-intl-tap.xml | ||
TAP_V8_BENCHMARKS := --junitout v8-benchmarks-tap.xml | ||
endif | ||
|
||
ifdef DISABLE_V8_I18N | ||
V8_TEST_NO_I18N := --noi18n | ||
V8_BUILD_NO_I18N := i18nsupport=off | ||
endif | ||
|
||
BUILDTYPE_LOWER := $(shell echo $(BUILDTYPE) | tr '[A-Z]' '[a-z]') | ||
|
||
# Determine EXEEXT | ||
EXEEXT := $(shell $(PYTHON) -c \ | ||
"import sys; print('.exe' if sys.platform == 'win32' else '')") | ||
|
@@ -81,12 +98,33 @@ distclean: | |
-rm -rf deps/icu | ||
-rm -rf deps/icu4c*.tgz deps/icu4c*.zip deps/icu-tmp | ||
-rm -f $(BINARYTAR).* $(TARBALL).* | ||
-rm -rf deps/v8/testing/gmock | ||
-rm -rf deps/v8/testing/gtest | ||
|
||
check: test | ||
|
||
cctest: all | ||
@out/$(BUILDTYPE)/$@ | ||
|
||
v8: | ||
tools/make-v8.sh v8 | ||
#cd deps/v8 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove? |
||
ifneq (,$(filter $(DESTCPU),x86)) | ||
+make -C deps/v8 $(V8_BUILD_NO_I18N); | ||
else | ||
ifneq (,$(filter $(ARCH),x86)) | ||
+make -C deps/v8 $(V8_BUILD_NO_I18N); | ||
else | ||
ifeq ($(ARCH)$(DESTCPU),) | ||
+make -C deps/v8 $(V8_BUILD_NO_I18N); | ||
else | ||
+make -C deps/v8 $(ARCH) $(V8_BUILD_NO_I18N); | ||
endif | ||
+make -C deps/v8 $(ARCH) $(V8_BUILD_NO_I18N); | ||
endif | ||
+make -C deps/v8 $(ARCH) $(V8_BUILD_NO_I18N); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Won't this run the same make command twice here? Style nits: the semicolons are not necessary and it's customary to write There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, you need |
||
endif | ||
|
||
test: | cctest # Depends on 'all'. | ||
$(PYTHON) tools/test.py --mode=release message parallel sequential -J | ||
$(MAKE) jslint | ||
|
@@ -184,6 +222,26 @@ test-timers: | |
test-timers-clean: | ||
$(MAKE) --directory=tools clean | ||
|
||
test-v8: | ||
# note: performs full test unless QUICKCHECK is specified | ||
deps/v8/tools/run-tests.py --arch=$(ARCH) --mode=$(BUILDTYPE_LOWER) $(V8_TEST_NO_I18N) \ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Shouldn't this use |
||
$(QUICKCHECK_ARG) --no-presubmit --shell-dir=deps/v8/out/$(ARCH).$(BUILDTYPE_LOWER) \ | ||
$(TAP_V8) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Indent seems a little off here and 10 lines down. Also, if you can keep these lines <= 80 columns, that'd be awesome. |
||
|
||
test-v8-intl: | ||
# note: performs full test unless QUICKCHECK is specified | ||
deps/v8/tools/run-tests.py --arch=$(ARCH) --mode=$(BUILDTYPE_LOWER) --no-presubmit \ | ||
$(QUICKCHECK_ARG) --shell-dir=deps/v8/out/$(ARCH).$(BUILDTYPE_LOWER) intl $(TAP_V8_INTL) | ||
|
||
test-v8-benchmarks: | ||
# note: this runs with --download-data so it'll go out and | ||
deps/v8/tools/run-tests.py --arch=$(ARCH) --mode=$(BUILDTYPE_LOWER) --download-data \ | ||
$(QUICKCHECK_ARG) --no-presubmit --shell-dir=deps/v8/out/$(ARCH).$(BUILDTYPE_LOWER) benchmarks \ | ||
$(TAP_V8_BENCHMARKS) | ||
|
||
test-v8-all: test-v8 test-v8-intl test-v8-benchmarks | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you add the names of the new rules to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Added v8 make command as well as all test commands (test-v8, test-v8-intl, test-v8-benchmarks, test-v8-all) to .PHONY. |
||
# runs all v8 tests | ||
|
||
apidoc_sources = $(wildcard doc/api/*.markdown) | ||
apidocs = $(addprefix out/,$(apidoc_sources:.markdown=.html)) \ | ||
$(addprefix out/,$(apidoc_sources:.markdown=.json)) | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -375,6 +375,11 @@ parser.add_option('--enable-static', | |
dest='enable_static', | ||
help='build as static library') | ||
|
||
parser.add_option('--with-v8-tests', | ||
action='store_true', | ||
dest='with_v8_tests', | ||
help='Build v8 test suite') | ||
|
||
(options, args) = parser.parse_args() | ||
|
||
# Expand ~ in the install prefix now, it gets written to multiple files. | ||
|
@@ -796,6 +801,8 @@ def configure_v8(o): | |
o['variables']['v8_optimized_debug'] = 0 # Compile with -O0 in debug builds. | ||
o['variables']['v8_random_seed'] = 0 # Use a random seed for hash tables. | ||
o['variables']['v8_use_snapshot'] = 'false' if options.without_snapshot else 'true' | ||
if options.with_v8_tests: | ||
o['variables']['with_v8_tests'] = 1 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Are the changes to |
||
|
||
def configure_openssl(o): | ||
o['variables']['node_use_openssl'] = b(not options.without_ssl) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: rename this to
V8_BUILD_OPTIONS
and append withV8_BUILD_OPTIONS += i18nsupport=off
, then I as a user can add flags of my own.