Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip broken tests on Windows ARM64 #47020

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

StefanStojanovic
Copy link
Contributor

@StefanStojanovic StefanStojanovic commented Mar 8, 2023

This PR marks 2 tests for skipping on Windows on ARM. The changes introduced here aim to enable passing JS test suites in the CI. There is another PR that focuses on native test suites. Together their goal is to enable Windows ARM64 tests in CI

cc @nodejs/platform-windows-arm

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Mar 8, 2023
@niyas-sait
Copy link
Contributor

Thanks, @StefanStojanovic. Looks good to me.

@StefanStojanovic StefanStojanovic changed the title Test: mark win arm64 flaky tests Marking broken tests on Windows ARM64 Mar 13, 2023
@StefanStojanovic StefanStojanovic changed the title Marking broken tests on Windows ARM64 Skip broken tests on Windows ARM64 Mar 13, 2023
@StefanStojanovic
Copy link
Contributor Author

@sxa @richardlau hey, I'm not sure who to ping for this. I saw you were active on ARM64 and some test PRs in the past so I picked you. Anyway, I wanted to see if there is something I can do to help move this forward.

I apologize for pinging you and if there is someone else who I should ping for this please let me know. Thanks in advance.

@StefanStojanovic
Copy link
Contributor Author

@richardlau @targos can one of you trigger CI and/or merge this, please?

@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 21, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 21, 2023
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@targos targos added commit-queue Add this label to land a pull request using GitHub Actions. windows Issues and PRs related to the Windows platform. arm Issues and PRs related to the ARM platform. labels Mar 22, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 22, 2023
@nodejs-github-bot nodejs-github-bot merged commit f086555 into nodejs:main Mar 22, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in f086555

nodejs-github-bot pushed a commit that referenced this pull request Mar 27, 2023
Refs: #47020
Refs: nodejs/build#3046
PR-URL: #47235
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
richardlau pushed a commit that referenced this pull request Mar 28, 2023
PR-URL: #47020
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
richardlau pushed a commit that referenced this pull request Mar 28, 2023
Refs: #47020
Refs: nodejs/build#3046
PR-URL: #47235
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
PR-URL: #47020
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
Refs: #47020
Refs: nodejs/build#3046
PR-URL: #47235
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
PR-URL: #47020
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
Refs: #47020
Refs: nodejs/build#3046
PR-URL: #47235
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arm Issues and PRs related to the ARM platform. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants