lib: Remove XXX comment in readline and change to output debuglog #4690
Conversation
| @@ -380,7 +381,7 @@ Interface.prototype._tabComplete = function() { | |||
| self.resume(); | |||
|
|
|||
| if (err) { | |||
| // XXX Log it somewhere? | |||
| debug(err); | |||
There was a problem hiding this comment.
Congratulations your 1st contribution.
You would be better to print more information. e.g.
debug('tab complete error ', err);like https://github.com/nodejs/node/blob/master/lib/repl.js#L230
yosuke-furukawa
added
the
good first issue
Fishrock123
added
readline
|
@kohei-takata Could you please prefix the commit message with Also please make sure the commit message (the first line, where the prefix is) is no longer than 50 characters. :) |
|
LGTM with the nits @Fishrock123 and @yosuke-furukawa mentioned addressed. |
Remove a comment that has a word 'XXX'. And add a line to output debuglog of error.
kohei-takata
force-pushed
the
remove_xxx_in_readline
branch
from
d506391
to
a854ec6
Compare
|
@yosuke-furukawa @Fishrock123 @jasnell |
|
LGTM pending CI |
|
Failures in CI look unrelated. Updated commit LGTM |
|
CI is a little more robust right now then it was 13 hours ago, so let's try CI again: |
|
CI is green! \o/ |
|
Great job @Trott. Great to see.
|
|
@Trott Thanks! |
Remove a comment that has a word 'XXX'. And add a line to output debuglog of error. PR-URL: #4690 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in ad63d35 |
Remove a comment that has a word 'XXX'. And add a line to output debuglog of error. PR-URL: #4690 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Remove a comment that has a word 'XXX'. And add a line to output debuglog of error. PR-URL: #4690 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Remove a comment that has a word 'XXX'. And add a line to output debuglog of error. PR-URL: #4690 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Remove a comment that has a word 'XXX'. And add a line to output debuglog of error. PR-URL: nodejs#4690 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Remove a comment that has a word 'XXX'. And add a line to output debuglog of error. PR-URL: nodejs#4690 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Remove a comment that has a word 'XXX'. And add a line to output debuglog of error. PR-URL: nodejs#4690 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Remove a comment that has a word 'XXX'. And add a line to output debuglog of error. PR-URL: nodejs#4690 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
refs #4642
Remove a comment that has a word 'XXX'.
And add a line to output debuglog of error.