deps: update V8 to 11.2 #46815

targos · 2023-02-24T13:18:59Z

No description provided.

nodejs-github-bot · 2023-02-24T13:19:04Z

Review requested:

@nodejs/gyp
@nodejs/v8-update

nodejs-github-bot · 2023-02-24T13:58:05Z

CI: https://ci.nodejs.org/job/node-test-pull-request/49978/

targos · 2023-02-24T14:51:31Z

There's still the Windows arm64 failure we saw recently on canary:

15:19:53   handler-outside-simulator.cc
15:19:53 C:\workspace\node-compile-windows\node\deps\v8\src\trap-handler\trap-handler-simulator.h(38,5): error C2143: syntax error: missing ';' before 'asm' [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_base_without_compiler_host.vcxproj]
15:19:53 C:\workspace\node-compile-windows\node\deps\v8\src\trap-handler\trap-handler-simulator.h(38,44): error C2290: C++ 'asm' syntax ignored. Use __asm. [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_base_without_compiler_host.vcxproj]
15:19:53   simulator-arm64.cc
15:19:53 C:\workspace\node-compile-windows\node\deps\v8\src\trap-handler\trap-handler-simulator.h(38,5): error C2143: syntax error: missing ';' before 'asm' [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_base_without_compiler_host.vcxproj]
15:19:53 C:\workspace\node-compile-windows\node\deps\v8\src\trap-handler\trap-handler-simulator.h(38,44): error C2290: C++ 'asm' syntax ignored. Use __asm. [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_base_without_compiler_host.vcxproj]

@nodejs/platform-windows-arm PTAL

pbo-linaro · 2023-02-24T14:55:16Z

@StefanStojanovic This would need you, as this is gonna block updating v8 later. An upstream patch, directly at v8, would be the best approach.

nodejs-github-bot · 2023-02-25T09:24:58Z

CI: https://ci.nodejs.org/job/node-test-pull-request/49995/

targos · 2023-02-26T12:01:04Z

There's also test.wpt/test-wasm-webapi that fails on ARM.

StefanStojanovic · 2023-02-27T14:11:48Z

@StefanStojanovic This would need you, as this is gonna block updating v8 later. An upstream patch, directly at v8, would be the best approach.

Thanks for letting me know @pbo-linaro, I'll take a look after I'm finished with the tasks I'm working on currently.

nodejs-github-bot · 2023-03-08T07:42:16Z

CI: https://ci.nodejs.org/job/node-test-pull-request/50274/

nodejs-github-bot · 2023-03-21T07:07:42Z

CI: https://ci.nodejs.org/job/node-test-pull-request/50509/

nodejs-github-bot · 2023-03-21T07:08:20Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5231/

nodejs-github-bot · 2023-03-21T07:14:29Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5231/

StefanStojanovic · 2023-03-21T11:37:12Z

Good 👍. It's a bit dirty, and probably break "ProbeMemory" function, but from what I understood, nodeJS does not use all this "simulator" stuff, so it should not impact any user (or test).

For upstreaming that to V8, it would be needed to clean things a bit:

use __declspec(align) to align variables declared

declare symbol alias for Probe Memory

FYI, I'm working on this in V8 to open a CL upstream. I agree with all said here and I'll update this PR with a CL link when opened.

nodejs-github-bot · 2023-03-21T12:34:47Z

CI: https://ci.nodejs.org/job/node-test-pull-request/50515/

nodejs-github-bot · 2023-03-21T22:37:37Z

CI: https://ci.nodejs.org/job/node-test-pull-request/50532/

targos · 2023-03-22T07:11:14Z

test.wpt/test-wasm-webapi Still fails a lot because of timeouts.

targos · 2023-03-22T08:57:25Z

There's definitely something wrong. I'm currently on test-equinix-debian10_container-armv7l-1.
Sometimes the test suite passes in less than two seconds, other times it hangs.

targos · 2023-03-22T09:50:02Z

For now I've reduced the hang to:

$ out/Release/node test/wpt/test-wasm-webapi.js instantiateStreaming-bad-imports.any.js
---- Non-object imports argument: null ----
[PASS] Non-object imports argument: null
---- Non-object imports argument: true ----
[PASS] Non-object imports argument: true
---- Non-object imports argument: "" ----
[PASS] Non-object imports argument: ""
---- Non-object imports argument: symbol "Symbol()" ----
[PASS] Non-object imports argument: symbol "Symbol()"

targos · 2023-03-22T10:02:47Z

/cc @tniessen since you implemented instantiateStreaming. Any idea how I could debug it further?

StefanStojanovic · 2023-03-22T15:35:51Z

A quick update, I've opened CL with ARM64 fixes upstream https://chromium-review.googlesource.com/c/v8/v8/+/4359712

pbo-linaro · 2023-03-22T15:42:42Z

Good work @StefanStojanovic, hope you'll get it accepted 👍

targos · 2023-03-25T12:46:35Z

I opened #47251 in parallel. Maybe we're lucky and these wasm issues are fixed.

targos · 2023-03-26T12:48:45Z

@bnoordhuis any idea?

This test is flaky on ARM with V8 >= 11.2. Skip it so we can update V8 before the release of Nodejs 20.0.0. PR-URL: #47292 Refs: #46815 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Darshan Sen <[email protected]>

targos · 2023-03-31T07:10:27Z

Working on landing #47251

This test is flaky on ARM with V8 >= 11.2. Skip it so we can update V8 before the release of Nodejs 20.0.0. PR-URL: #47292 Refs: #46815 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Darshan Sen <[email protected]>

targos added the semver-major PRs that contain breaking changes and should be released in the next major version. label Feb 24, 2023

nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Feb 24, 2023

targos added request-ci Add this label to start a Jenkins CI on a PR. and removed build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency. needs-ci PRs that need a full CI run. labels Feb 24, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 24, 2023

This comment was marked as outdated.

Sign in to view

targos force-pushed the v8-112 branch from 651137f to fd0e2d6 Compare February 24, 2023 13:50

targos added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 24, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 24, 2023

targos added build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency. labels Feb 24, 2023

github-actions bot mentioned this pull request Feb 25, 2023

CI Reliability 2023-02-25 nodejs/reliability#506

Open

28 tasks

github-actions bot mentioned this pull request Feb 26, 2023

CI Reliability 2023-02-26 nodejs/reliability#507

Open

15 tasks

github-actions bot mentioned this pull request Feb 27, 2023

CI Reliability 2023-02-27 nodejs/reliability#508

Open

13 tasks

github-actions bot mentioned this pull request Feb 28, 2023

CI Reliability 2023-02-28 nodejs/reliability#509

Open

16 tasks

targos force-pushed the v8-112 branch from fd0e2d6 to 1e919b9 Compare March 8, 2023 07:32

targos added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 8, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 8, 2023

targos added 2 commits March 21, 2023 08:00

tools: update V8 gypfiles for 11.0

92eb004

tools: update V8 gypfiles for 11.1

f9b0754

targos force-pushed the v8-112 branch from a94492d to f9b0754 Compare March 21, 2023 07:00

targos added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 21, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 21, 2023

github-actions bot mentioned this pull request Mar 22, 2023

CI Reliability 2023-03-22 nodejs/reliability#532

Open

19 tasks

github-actions bot mentioned this pull request Mar 23, 2023

CI Reliability 2023-03-23 nodejs/reliability#533

Open

33 tasks

targos mentioned this pull request Mar 29, 2023

test: skip instantiateStreaming-bad-imports WPT #47292

Merged

targos closed this Mar 31, 2023

targos deleted the v8-112 branch April 5, 2024 09:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

deps: update V8 to 11.2 #46815

deps: update V8 to 11.2 #46815

targos commented Feb 24, 2023

nodejs-github-bot commented Feb 24, 2023

This comment was marked as outdated.

nodejs-github-bot commented Feb 24, 2023

targos commented Feb 24, 2023

pbo-linaro commented Feb 24, 2023

nodejs-github-bot commented Feb 25, 2023

targos commented Feb 26, 2023

StefanStojanovic commented Feb 27, 2023

nodejs-github-bot commented Mar 8, 2023

nodejs-github-bot commented Mar 21, 2023

nodejs-github-bot commented Mar 21, 2023

nodejs-github-bot commented Mar 21, 2023

StefanStojanovic commented Mar 21, 2023

nodejs-github-bot commented Mar 21, 2023

nodejs-github-bot commented Mar 21, 2023

targos commented Mar 22, 2023

targos commented Mar 22, 2023

targos commented Mar 22, 2023

targos commented Mar 22, 2023

StefanStojanovic commented Mar 22, 2023

pbo-linaro commented Mar 22, 2023

targos commented Mar 25, 2023

targos commented Mar 26, 2023

targos commented Mar 31, 2023

deps: update V8 to 11.2 #46815

deps: update V8 to 11.2 #46815

Conversation

targos commented Feb 24, 2023

nodejs-github-bot commented Feb 24, 2023

This comment was marked as outdated.

nodejs-github-bot commented Feb 24, 2023

targos commented Feb 24, 2023

pbo-linaro commented Feb 24, 2023

nodejs-github-bot commented Feb 25, 2023

targos commented Feb 26, 2023

StefanStojanovic commented Feb 27, 2023

nodejs-github-bot commented Mar 8, 2023

nodejs-github-bot commented Mar 21, 2023

nodejs-github-bot commented Mar 21, 2023

nodejs-github-bot commented Mar 21, 2023

StefanStojanovic commented Mar 21, 2023

nodejs-github-bot commented Mar 21, 2023

nodejs-github-bot commented Mar 21, 2023

targos commented Mar 22, 2023

targos commented Mar 22, 2023

targos commented Mar 22, 2023

targos commented Mar 22, 2023

StefanStojanovic commented Mar 22, 2023

pbo-linaro commented Mar 22, 2023

targos commented Mar 25, 2023

targos commented Mar 26, 2023

targos commented Mar 31, 2023