-
Notifications
You must be signed in to change notification settings - Fork 30.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mention vcpkg port in docs #46641
Mention vcpkg port in docs #46641
Conversation
Review requested:
|
installed by the following commands. | ||
|
||
```bash | ||
vcpkg install node-api |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't find these packages on https://vcpkg.io/en/packages.html and I'm not aware of an existing release process that publishes these packages.
@mhdawson please correct me if I'm missing it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like these are referencing the ports added by:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like these are referencing the ports added by:
Yeah, that's true. I'm not sure what revision of vcpkg does the site use, but those packages are available for users.
Unlike many package managers vcpkg consists of build recipes instead of storing files in the cloud. Those build recipes are being maintained by the community and Microsoft.
The usual workflow is to have vcpkg repo cloned somewhere on your machine. So, once you cloned latest vcpkg or pulled latest changes, you'd be able to run vcpkg install node-api
and vcpkg install node-addon-api
.
After running those commands you can see a brief explanation on how to use node-api/node-addon-api with your existing CMake project (and some CMake lines to copy-paste).
@vmoroz is this something you are aware of? |
@mhdawson , I was not aware about the node-api and node-addon-api ports to vcpkg. @Pospelove, I wonder if you could work with the Node-API team to make the vcpkg offering to be more compelling:
|
@vmoroz Thanks for your interest in this! I'll definitely be glad to finish that work.
Yeah, I think so. I'll make a PR for that.
I've just updated node-addon-api to the newest 6.0 release (see microsoft/vcpkg#29599) |
@vmoroz I have a couple of questions:
My first idea would be to just change the version from 18.0.2 to 8 in the node-api port, but keep downloading 18.0.2 dist. Do you think this is a good idea? |
@Pospelove for cmake-js I did some digging and found that it is possible to generate the https://github.com/cmake-js/cmake-js/blob/master/lib/cMake.js#L293-L315 and https://github.com/cmake-js/cmake-js/blob/master/README.md?plain=1#L124-L127 are the interesting snippets. It would of course be nice to have these prebuilt and possible to bundle, but this way avoids distributing 'large' files, and could also be used to limit the possible symbols that can be linked |
@Julusian Thanks! it helps |
@KevinEady is working on automation to do the update so we'll be able to better keep up to date. I think that is about to land so we should be testing it out on an update soon. |
This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open. |
Closing this because it has stalled. Feel free to reopen if this issue/PR is still relevant, or to ping the collaborator who labelled it stalled if you have any questions. |
No description provided.