crypto: re-add padding for AES-KW wrapped JWKs #46563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panva
added
crypto
|
Review requested:
|
github-actions
bot
added
request-ci-failed
Failed to start CI- Validating Jenkins credentials ✖ Jenkins credentials invalidhttps://github.com/nodejs/node/actions/runs/4123171581 |
panva
removed
the
request-ci-failed
jasnell
approved these changes
Feb 9, 2023
panva
added
request-ci
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
panva
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 4c1a277 |
panva
added a commit
to panva/node
that referenced
this pull request
Feb 17, 2023
PR-URL: nodejs#46563 Reviewed-By: James M Snell <[email protected]> Backport-PR-URL: nodejs#46252
panva
added a commit
to panva/node
that referenced
this pull request
Mar 5, 2023
PR-URL: nodejs#46563 Reviewed-By: James M Snell <[email protected]> Backport-PR-URL: nodejs#46252
panva
added a commit
to panva/node
that referenced
this pull request
Mar 8, 2023
PR-URL: nodejs#46563 Reviewed-By: James M Snell <[email protected]> Backport-PR-URL: nodejs#46252
panva
added a commit
to panva/node
that referenced
this pull request
Apr 3, 2023
PR-URL: nodejs#46563 Reviewed-By: James M Snell <[email protected]>
panva
added a commit
to panva/node
that referenced
this pull request
Apr 3, 2023
PR-URL: nodejs#46563 Reviewed-By: James M Snell <[email protected]> Backport-PR-URL: nodejs#47383
panva
added a commit
to panva/node
that referenced
this pull request
Apr 18, 2023
PR-URL: nodejs#46563 Reviewed-By: James M Snell <[email protected]> Backport-PR-URL: nodejs#47383
panva
added a commit
to panva/node
that referenced
this pull request
Apr 18, 2023
PR-URL: nodejs#46563 Reviewed-By: James M Snell <[email protected]> Backport-PR-URL: nodejs#46252
panva
added a commit
to panva/node
that referenced
this pull request
May 15, 2023
PR-URL: nodejs#46563 Reviewed-By: James M Snell <[email protected]> Backport-PR-URL: nodejs#47336
danielleadams
pushed a commit
that referenced
this pull request
May 17, 2023
PR-URL: #46563 Reviewed-By: James M Snell <[email protected]> Backport-PR-URL: #46252
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This re-introduces auto-padding of JWK exported keys that are to be wrapped with AES-KW if they don't meet the pre-conditions for AES-KW (length % 8 === 0). This is optional as per NOTE in step 13 of https://w3c.github.io/webcrypto/#SubtleCrypto-method-wrapKey.
This is being re-added because I have unfortunately removed it in #46067 due to not having any effect on test or WPT outcome. Now with enabled test vectors for it in
test/parallel/test-webcrypto-wrap-unwrap.js.When this PR lands I will add it to the v18.x backport of #46067 (#46252).