-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib: refactor to use validateBuffer
#46489
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
deokjinkim:230204_lib_refactor_validatebuffer
Feb 6, 2023
Merged
lib: refactor to use validateBuffer
#46489
nodejs-github-bot
merged 1 commit into
nodejs:main
from
deokjinkim:230204_lib_refactor_validatebuffer
Feb 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use validateBuffer to remove duplicate implementation.
Review requested:
|
nodejs-github-bot
added
http2
Issues or PRs related to the http2 subsystem.
needs-ci
PRs that need a full CI run.
tls
Issues and PRs related to the tls subsystem.
vm
Issues and PRs related to the vm subsystem.
labels
Feb 3, 2023
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Feb 3, 2023
lpinca
approved these changes
Feb 3, 2023
aduh95
approved these changes
Feb 3, 2023
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Feb 3, 2023
RafaelGSS
approved these changes
Feb 4, 2023
22 tasks
rickyes
approved these changes
Feb 5, 2023
19 tasks
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Feb 6, 2023
trivikr
approved these changes
Feb 6, 2023
deokjinkim
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
commit-queue
Add this label to land a pull request using GitHub Actions.
labels
Feb 6, 2023
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Feb 6, 2023
Landed in d43b532 |
18 tasks
This doesn't land cleanly on v19.x-staging, could it please be backported. |
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
Use validateBuffer to remove duplicate implementation. PR-URL: #46489 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Ricky Zhou <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
http2
Issues or PRs related to the http2 subsystem.
needs-ci
PRs that need a full CI run.
tls
Issues and PRs related to the tls subsystem.
vm
Issues and PRs related to the vm subsystem.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use validateBuffer to remove duplicate implementation.