V18.14.0 proposal

.eslintrc.js

@@ -68,7 +68,7 @@ module.exports = {
       files: ['**/*.md/*.cjs', '**/*.md/*.js'],
       parserOptions: {
         sourceType: 'script',
-        ecmaFeatures: { impliedStrict: true }
+        ecmaFeatures: { impliedStrict: true },
       },
       rules: { strict: 'off' },
     },
@@ -103,11 +103,11 @@ module.exports = {
         },
         {
           name: 'Buffer',
-          message: 'Import Buffer instead of using the global'
+          message: 'Import Buffer instead of using the global',
         },
         {
           name: 'process',
-          message: 'Import process instead of using the global'
+          message: 'Import process instead of using the global',
         },
       ] },
     },
@@ -134,13 +134,7 @@ module.exports = {
         ignorePattern: '.*',
       },
     }],
-    'comma-dangle': ['error', {
-      arrays: 'always-multiline',
-      exports: 'only-multiline',
-      functions: 'only-multiline',
-      imports: 'only-multiline',
-      objects: 'only-multiline',
-    }],
+    'comma-dangle': ['error', 'always-multiline'],
     'comma-spacing': 'error',
     'comma-style': 'error',
     'computed-property-spacing': 'error',

.github/CODEOWNERS

@@ -1,9 +1,12 @@
 # Node.js Project Codeowners
 
-# 1. Codeowners must always be teams, never individuals
-# 2. Each codeowner team should contain at least one TSC member
-# 3. PRs touching any code with a codeowner must be signed off by at least one
-#    person on the code owner team.
+# This file does not define any requirements for landing PRs.
+# Its purpose is to allow automation of courtesy pings to the
+# relevant team(s) when any of the paths listed here are modified.
+# Criteria for landing PRs are defined in
+# https://github.com/nodejs/node/blob/main/doc/contributing/collaborator-guide.md#code-reviews.
+#
+# Codeowners must always be teams, never individuals.
 
 # tsc
 
@@ -71,16 +74,18 @@
 /src/node_http2* @nodejs/http2 @nodejs/net
 /src/node_mem* @nodejs/http2
 
-# modules
+# modules, including loaders
 
-/doc/api/modules.md @nodejs/modules
-/doc/api/esm.md @nodejs/modules
-/doc/api/module.md @nodejs/modules
-/doc/api/packages.md @nodejs/modules
-/lib/module.js @nodejs/modules
-/lib/internal/modules/* @nodejs/modules
-/lib/internal/bootstrap/loaders.js @nodejs/modules
-/src/module_wrap* @nodejs/modules @nodejs/vm
+/doc/api/esm.md @nodejs/modules @nodejs/loaders
+/doc/api/module.md @nodejs/modules @nodejs/loaders
+/doc/api/modules.md @nodejs/modules @nodejs/loaders
+/doc/api/packages.md @nodejs/modules @nodejs/loaders
+/lib/internal/bootstrap/loaders.js @nodejs/modules @nodejs/loaders
+/lib/internal/modules/* @nodejs/modules @nodejs/loaders
+/lib/internal/process/esm_loader.js @nodejs/modules @nodejs/loaders
+/lib/internal/process/execution.js @nodejs/modules @nodejs/loaders
+/lib/module.js @nodejs/modules @nodejs/loaders
+/src/module_wrap* @nodejs/modules @nodejs/loaders @nodejs/vm
 
 # Node-API
 
@@ -96,6 +101,7 @@
 /tools/gyp/**/* @nodejs/gyp
 
 # WASI
+
 /deps/uvwasi/ @nodejs/wasi
 /doc/api/wasi.md @nodejs/wasi
 /lib/wasi.js @nodejs/wasi
@@ -113,10 +119,20 @@
 /tools/snapshot/* @nodejs/startup
 
 # V8
+
 /deps/v8/* @nodejs/v8-update
 /tools/v8_gypfiles/* @nodejs/v8-update
 
 # Actions
 
 /.github/workflows/* @nodejs/actions
 /tools/actions/* @nodejs/actions
+
+# Test runner
+
+/test/message/test_runner_* @nodejs/test_runner
+/test/parallel/test-runner-* @nodejs/test_runner
+/doc/api/test.md @nodejs/test_runner
+/lib/test.js @nodejs/test_runner
+/lib/internal/main/test_runner.js @nodejs/test_runner
+/lib/internal/test_runner/* @nodejs/test_runner

.github/workflows/authors.yml

@@ -19,7 +19,7 @@ jobs:
           fetch-depth: '0'  # This is required to actually get all the authors
           persist-credentials: false
       - run: tools/update-authors.mjs  # Run the AUTHORS tool
-      - uses: gr2m/create-or-update-pull-request-action@dc1726cbf4dd3ce766af4ec29cfb660e0125e8ee
+      - uses: gr2m/create-or-update-pull-request-action@77596e3166f328b24613f7082ab30bf2d93079d5
         # Creates a PR or update the Action's existing PR, or
         # no-op if the base branch is already up-to-date.
         env:
@@ -30,6 +30,9 @@ jobs:
             Here are some new additions to the AUTHORS file.
             This is an automatically generated PR by the
             `authors.yml` GitHub Action, which runs `tools/update-authors.mjs`.
+            Check the output of
+            ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}
+            for possible duplicates.
           branch: actions/authors-update  # Custom branch *just* for this Action.
           commit-message: 'meta: update AUTHORS'
           labels: meta

.github/workflows/close-stale-feature-requests.yml

@@ -39,7 +39,7 @@ jobs:
     if: github.repository == 'nodejs/node'
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/stale@v4
+      - uses: actions/stale@v7
         with:
           repo-token: ${{ secrets.GITHUB_TOKEN }}
           days-before-stale: 180

.github/workflows/close-stalled.yml

@@ -20,7 +20,7 @@ jobs:
     if: github.repository == 'nodejs/node'
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/stale@v4
+      - uses: actions/stale@v7
         with:
           repo-token: ${{ secrets.GITHUB_TOKEN }}
           days-before-close: 30

.github/workflows/find-inactive-collaborators.yml

@@ -33,7 +33,7 @@ jobs:
         run: tools/find-inactive-collaborators.mjs
 
       - name: Open pull request
-        uses: gr2m/create-or-update-pull-request-action@dc1726cbf4dd3ce766af4ec29cfb660e0125e8ee
+        uses: gr2m/create-or-update-pull-request-action@77596e3166f328b24613f7082ab30bf2d93079d5
         # Creates a PR or update the Action's existing PR, or
         # no-op if the base branch is already up-to-date.
         env:

.github/workflows/find-inactive-tsc.yml

@@ -42,7 +42,7 @@ jobs:
         run: tools/find-inactive-tsc.mjs >> $GITHUB_ENV
 
       - name: Open pull request
-        uses: gr2m/create-or-update-pull-request-action@dc1726cbf4dd3ce766af4ec29cfb660e0125e8ee
+        uses: gr2m/create-or-update-pull-request-action@77596e3166f328b24613f7082ab30bf2d93079d5
         # Creates a PR or update the Action's existing PR, or
         # no-op if the base branch is already up-to-date.
         env:

.github/workflows/license-builder.yml

@@ -21,7 +21,7 @@ jobs:
         with:
           persist-credentials: false
       - run: ./tools/license-builder.sh  # Run the license builder tool
-      - uses: gr2m/create-or-update-pull-request-action@dc1726cbf4dd3ce766af4ec29cfb660e0125e8ee
+      - uses: gr2m/create-or-update-pull-request-action@77596e3166f328b24613f7082ab30bf2d93079d5
         # Creates a PR or update the Action's existing PR, or
         # no-op if the base branch is already up-to-date.
         env:

.github/workflows/timezone-update.yml

@@ -40,7 +40,7 @@ jobs:
         run: echo "${{ env.new_version }}" > test/fixtures/tz-version.txt
 
       - name: Open Pull Request
-        uses: gr2m/create-or-update-pull-request-action@dc1726cbf4dd3ce766af4ec29cfb660e0125e8ee  # Create a PR or update the Action's existing PR
+        uses: gr2m/create-or-update-pull-request-action@77596e3166f328b24613f7082ab30bf2d93079d5  # Create a PR or update the Action's existing PR
         env:
           GITHUB_TOKEN: ${{ secrets.GH_USER_TOKEN }}
         with:

.github/workflows/tools.yml

@@ -21,12 +21,11 @@ jobs:
             subsystem: tools
             label: tools
             run: |
-              cd tools
               NEW_VERSION=$(npm view eslint dist-tags.latest)
-              CURRENT_VERSION=$(node -p "require('./node_modules/eslint/package.json').version")
+              CURRENT_VERSION=$(node -p "require('./tools/node_modules/eslint/package.json').version")
               if [ "$NEW_VERSION" != "$CURRENT_VERSION" ]; then
                 echo "NEW_VERSION=$NEW_VERSION" >> $GITHUB_ENV
-                ./update-eslint.sh
+                ./tools/dep_updaters/update-eslint.sh
               fi
           - id: corepack
             subsystem: deps
@@ -78,6 +77,16 @@ jobs:
                 echo "NEW_VERSION=$NEW_VERSION" >> $GITHUB_ENV
                 ./tools/update-undici.sh
               fi
+          - id: postject
+            subsystem: deps
+            label: dependencies
+            run: |
+              NEW_VERSION=$(npm view postject dist-tags.latest)
+              CURRENT_VERSION=$(node -p "require('./test/fixtures/postject-copy/node_modules/postject/package.json').version")
+              if [ "$NEW_VERSION" != "$CURRENT_VERSION" ]; then
+                echo "NEW_VERSION=$NEW_VERSION" >> $GITHUB_ENV
+                ./tools/dep_updaters/update-postject.sh
+              fi
           - id: base64
             subsystem: deps
             label: dependencies
@@ -125,14 +134,24 @@ jobs:
                 echo "NEW_VERSION=$NEW_VERSION" >> $GITHUB_ENV
                 ./tools/dep_updaters/update-libuv.sh "$NEW_VERSION"
               fi
+          - id: simdutf
+            subsystem: deps
+            label: dependencies
+            run: |
+              NEW_VERSION=$(gh api repos/simdutf/simdutf/releases/latest -q '.tag_name|ltrimstr("v")')
+              CURRENT_VERSION=$(grep "#define SIMDUTF_VERSION" ./deps/simdutf/simdutf.h | sed -n "s/^.*VERSION \(.*\)/\1/p")
+              if [ "$NEW_VERSION" != "$CURRENT_VERSION" ]; then
+                echo "NEW_VERSION=$NEW_VERSION" >> $GITHUB_ENV
+                ./tools/dep_updaters/update-simdutf.sh "$NEW_VERSION"
+              fi
     steps:
       - uses: actions/checkout@v3
         with:
           persist-credentials: false
       - run: ${{ matrix.run }}
         env:
           GITHUB_TOKEN: ${{ secrets.GH_USER_TOKEN }}
-      - uses: gr2m/create-or-update-pull-request-action@dc1726cbf4dd3ce766af4ec29cfb660e0125e8ee
+      - uses: gr2m/create-or-update-pull-request-action@77596e3166f328b24613f7082ab30bf2d93079d5
         # Creates a PR or update the Action's existing PR, or
         # no-op if the base branch is already up-to-date.
         env:

.gitignore

@@ -136,10 +136,11 @@ tools/*/*.i.tmp
 /deps/npm/node_modules/.bin/
 # Respect V8's .gitignore
 !deps/v8/**
-# Ignore the libuv book and GitHub templates
-/deps/uv/.github/
+# Ignore the libuv book
 /deps/uv/docs/code/
 /deps/uv/docs/src/guide/
+# Ignore .github directories
+/deps/**/.github/
 # Ignore dependencies fetched by tools/v8/fetch_deps.py
 /deps/.cipd
 

.mailmap

@@ -141,6 +141,7 @@ David Mark Clements <[email protected]> <[email protected]>
 David Siegel <[email protected]> <[email protected]>
 DC <[email protected]>
 Deepjyoti Mondal <[email protected]>
+Deokjin Kim <[email protected]> <[email protected]>
 dnlup <[email protected]> <[email protected]>
 Domenic Denicola <[email protected]>
 Domenic Denicola <[email protected]> <[email protected]>

AUTHORS

@@ -3585,5 +3585,15 @@ Alex Hunt <[email protected]>
 Debadree Chatterjee <[email protected]>
 Gabriela Gutierrez <[email protected]>
 emirgoren <[email protected]>
+Pulkit Gupta <[email protected]>
+Fabien Michel <[email protected]>
+A. Wilcox <[email protected]>
+Daniel Lemire <[email protected]>
+Eric Mutta <[email protected]>
+Vadim <[email protected]>
+Aaron Friel <[email protected]>
+Vaishno Chaitanya <[email protected]>
+Jonathan Diaz <[email protected]>
+Mike Roth <[email protected]>
 
 # Generated by tools/update-authors.mjs

CHANGELOG.md

@@ -33,7 +33,8 @@ release.
 </tr>
 <tr>
   <td valign="top">
-<b><a href="doc/changelogs/CHANGELOG_V18.md#18.13.0">18.13.0</a></b><br/>
+<b><a href="doc/changelogs/CHANGELOG_V18.md#18.14.0">18.14.0</a></b><br/>
+<a href="doc/changelogs/CHANGELOG_V18.md#18.13.0">18.13.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V18.md#18.12.1">18.12.1</a><br/>
 <a href="doc/changelogs/CHANGELOG_V18.md#18.12.0">18.12.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V18.md#18.11.0">18.11.0</a><br/>