Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add getRandomValues return length #46357

Merged
merged 1 commit into from
May 13, 2023
Merged

test: add getRandomValues return length #46357

merged 1 commit into from
May 13, 2023

Conversation

MrJithil
Copy link
Member

Added test to check the return results getRandomValues

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jan 26, 2023
@panva panva added crypto Issues and PRs related to the crypto subsystem. webcrypto labels Jan 26, 2023
@MrJithil MrJithil force-pushed the addGetRandomValuesReturnTest branch from e9d9c3f to 64e8f23 Compare May 13, 2023 04:34
@MrJithil MrJithil requested a review from panva May 13, 2023 04:34
@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. label May 13, 2023
@panva panva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 13, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 13, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51771/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51772/

@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label May 13, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 13, 2023
@nodejs-github-bot nodejs-github-bot merged commit e74b84e into nodejs:main May 13, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in e74b84e

targos pushed a commit that referenced this pull request May 14, 2023
@MrJithil @targos
test: add getRandomValues return length
d039d51 
PR-URL: #46357
Reviewed-By: Filip Skokan <[email protected]>
targos pushed a commit that referenced this pull request May 15, 2023
@MrJithil @targos
test: add getRandomValues return length
bb33c74 
PR-URL: #46357
Reviewed-By: Filip Skokan <[email protected]>
@targos targos mentioned this pull request May 15, 2023
Merged
@danielleadams danielleadams added the backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. label Jul 5, 2023
@danielleadams
Copy link
Contributor

This broke the test suite in v18.x-staging - I think it's dependent on another commit that was removed, so it will need to be backported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panva panva panva approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. webcrypto
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MrJithil @nodejs-github-bot @danielleadams @panva