Skip to content

http: throw error if options of http.Server is array #46283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 6 commits into from
Jan 25, 2023
+34 −23
Merged

http: throw error if options of http.Server is array #46283

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
59dbe4b
http: throw error if options of http.Server is array
deokjinkim Jan 20, 2023
882d62d
refactor to use validateObject
deokjinkim Jan 22, 2023
fc78793
use kEmptyObject for options and apply same change to https.server
deokjinkim Jan 24, 2023
548bdf5
fixup! pass ommited noDelay option in https
deokjinkim Jan 24, 2023
141501d
remove overwriting options
deokjinkim Jan 24, 2023
a41a496
fixup! lint error
deokjinkim Jan 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/_http_server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -503,7 +503,7 @@ function Server(options, requestListener) {
if (typeof options === 'function') {
requestListener = options;
options = {};
} else if (options == null || typeof options === 'object') {
} else if (options == null || (typeof options === 'object' && !ArrayIsArray(options))) {
options = { ...options };
} else {
throw new ERR_INVALID_ARG_TYPE('options', 'object', options);
Comment thread
aduh95 marked this conversation as resolved.
Outdated
Expand Down
5 changes: 1 addition & 4 deletions test/parallel/test-http-server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,7 @@ const http = require('http');
const url = require('url');
const qs = require('querystring');

// TODO: documentation does not allow Array as an option, so testing that
// should fail, but currently http.Server does not typecheck further than
// if `option` is `typeof object` - so we don't test that here right now
const invalid_options = [ 'foo', 42, true ];
const invalid_options = [ 'foo', 42, true, [] ];

invalid_options.forEach((option) => {
assert.throws(() => {
Expand Down