Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update http.setMaxIdleHTTPParsers arguments #46168

Merged
merged 2 commits into from
Jan 14, 2023
Merged

doc: update http.setMaxIdleHTTPParsers arguments #46168

merged 2 commits into from
Jan 14, 2023

Conversation

debadree25
Copy link
Member

Fixes: #46160

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem. labels Jan 11, 2023
mcollina
mcollina approved these changes Jan 11, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 11, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 11, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48938/

mscdex
mscdex reviewed Jan 11, 2023
View reviewed changes
doc/api/http.md Outdated Show resolved Hide resolved
This was referenced Jan 12, 2023
Open
Open
mcollina
mcollina approved these changes Jan 13, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48974/

@github-actions github-actions bot mentioned this pull request Jan 14, 2023
Open
19 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48983/

@mcollina mcollina added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jan 14, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 14, 2023
@nodejs-github-bot nodejs-github-bot merged commit 67a9ed3 into nodejs:main Jan 14, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 67a9ed3

@github-actions github-actions bot mentioned this pull request Jan 15, 2023
Open
16 tasks
@GulajavaMinistudio GulajavaMinistudio mentioned this pull request Jan 15, 2023
Merged
This was referenced Jan 16, 2023
Open
Open
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Jan 17, 2023
@debadree25 @RafaelGSS
doc: update http.setMaxIdleHTTPParsers arguments
337bfd0 
Fixes: nodejs#46160
PR-URL: nodejs#46168
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Jan 20, 2023
@debadree25 @RafaelGSS
doc: update http.setMaxIdleHTTPParsers arguments
6e355ef 
Fixes: #46160
PR-URL: #46168
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Jan 20, 2023
Merged
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
@debadree25 @juanarbol
doc: update http.setMaxIdleHTTPParsers arguments
852dc6c 
Fixes: #46160
PR-URL: #46168
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@juanarbol juanarbol mentioned this pull request Jan 28, 2023
Merged
juanarbol pushed a commit that referenced this pull request Jan 31, 2023
@debadree25 @juanarbol
doc: update http.setMaxIdleHTTPParsers arguments
9bfd404 
Fixes: #46160
PR-URL: #46168
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mscdex mscdex mscdex left review comments

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

@aymen94 aymen94 aymen94 approved these changes

@lpinca lpinca lpinca approved these changes

@ShogunPanda ShogunPanda ShogunPanda approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

doc: http.setMaxIdleHTTPParsers is missing a traditional function signature
9 participants
@debadree25 @nodejs-github-bot @mcollina @mscdex @ShogunPanda @lpinca @aymen94 @RaisinTen @VoltrexKeyva