lib: implement finished for webstreams #45898
Closed
+37
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
|
I don't think using the adapters is the right path. |
Thanks, any suggestions? re-implementing from scratch? |
|
Add a few more ifs in the current finished implementation to handle WHATWG Streams. |
Ok attempting to do so thank you! |
|
Closing the pr for the meanwhile will reopen it once i am able to figure out a little better |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Opening this PR as a draft to know if am on the right path and to get some comments]
I have been trying to implement the finished function to work on webstreams so far I am trying to use the adapters to convert the webstreams to streams but when trying to test it seems like 'end' event is not triggered for the readable stream that is created by the adapter function? could this be bug or am I doing something wrong?
Any help would be greatly appreciated and I will try to finish the full issue if get some clarity
Thank You in advance!
Refs: #39316