-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
benchmark: add variety of inputs to text-encoder #45787
Merged
nodejs-github-bot
merged 2 commits into
nodejs:main
from
anonrig:benchmark/text-encoder-into
Dec 10, 2022
Merged
benchmark: add variety of inputs to text-encoder #45787
nodejs-github-bot
merged 2 commits into
nodejs:main
from
anonrig:benchmark/text-encoder-into
Dec 10, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
benchmark
Issues and PRs related to the benchmark subsystem.
util
Issues and PRs related to the built-in util module.
labels
Dec 8, 2022
anonrig
added
performance
Issues and PRs related to the performance of Node.js.
request-ci
Add this label to start a Jenkins CI on a PR.
util
Issues and PRs related to the built-in util module.
benchmark
Issues and PRs related to the benchmark subsystem.
and removed
util
Issues and PRs related to the built-in util module.
benchmark
Issues and PRs related to the benchmark subsystem.
labels
Dec 8, 2022
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Dec 8, 2022
addaleax
approved these changes
Dec 8, 2022
anonrig
added
commit-queue-squash
Add this label to instruct the Commit Queue to squash all the PR commits into the first one.
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
labels
Dec 8, 2022
addaleax
approved these changes
Dec 8, 2022
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Dec 8, 2022
lpinca
approved these changes
Dec 8, 2022
anonrig
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Dec 8, 2022
5 tasks
daeyeon
approved these changes
Dec 9, 2022
9 tasks
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Dec 10, 2022
Landed in b06fd8c |
This was referenced Dec 11, 2022
ErickWendel
pushed a commit
to ErickWendel/node
that referenced
this pull request
Dec 12, 2022
PR-URL: nodejs#45787 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]>
targos
pushed a commit
that referenced
this pull request
Dec 12, 2022
PR-URL: #45787 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]>
13 tasks
targos
pushed a commit
that referenced
this pull request
Dec 13, 2022
PR-URL: #45787 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
PR-URL: #45787 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
PR-URL: #45787 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 3, 2023
PR-URL: #45787 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 4, 2023
PR-URL: #45787 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 5, 2023
PR-URL: #45787 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
benchmark
Issues and PRs related to the benchmark subsystem.
commit-queue-squash
Add this label to instruct the Commit Queue to squash all the PR commits into the first one.
performance
Issues and PRs related to the performance of Node.js.
util
Issues and PRs related to the built-in util module.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is taking from my previous pull request, and updates the text-encoder types to include ascii, latin and utf8 characters to have a much more broad benchmarking for text-encoder.
Referencing #45701