Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: tap parser fails when test name includes non ASCII characters #45741

Closed
wants to merge 2 commits into from
Closed

fix: tap parser fails when test name includes non ASCII characters #45741

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b1fda06
fix: tap parser fails when test name includes non ASCII characters
pulkit-30 Dec 5, 2022
07a6ab7
replaced ascii.test method with RegExpPrototypeExec method
pulkit-30 Dec 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion lib/internal/test_runner/tap_lexer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,7 +471,8 @@ class TapLexer {
return (
(char >= 'a' && char <= 'z') ||
(char >= 'A' && char <= 'Z') ||
this.#isSpecialCharacterSymbol(char)
this.#isSpecialCharacterSymbol(char) ||
this.#isNonASCIISymbol(char)
);
}

Expand All @@ -482,6 +483,11 @@ class TapLexer {
return '!"$%&\'()*,./:;<=>?@[]^_`{|}~'.indexOf(char) > -1;
}

#isNonASCIISymbol(char) {
const ascii = /^[ -~]+$/;
return !ascii.test(char);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return !ascii.test(char);
return RegExpPrototypeExec(ascii, char) === null;

}

#isWhitespaceSymbol(char) {
return char === ' ' || char === '\t';
}
Expand Down