Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buffer: introduce Buffer.encode() method #4565

Closed
wants to merge 1 commit into from
Closed

buffer: introduce Buffer.encode() method #4565

wants to merge 1 commit into from

Commits on Jan 7, 2016

  1. buffer: introduce Buffer.encode() method 

    Buffer constructor has too much behaviour.

it is usual to convert string to Buffer in the form of new
Buffer(str).

If don't check type of first argument, new Buffer(number) can lead
Buffer vulnerability. For example:

- https://github.com/websockets/ws/releases/tag/1.0.1
- qiniu/nodejs-sdk#123

Introduce Buffer.encode() method to be explicit abort encoding.
    @JacksonTian
    JacksonTian committed Jan 7, 2016
    Configuration menu
    Copy the full SHA
    1827b5d View commit details
    Browse the repository at this point in the history