Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: use enum class instead of enum in node_i18n #45646

Merged
merged 4 commits into from
Nov 30, 2022

Commits on Nov 28, 2022

  1. src: use enum class instead of enum in node_i18n

    "enum class" has more advantages than "enum" because
    it's strongly typed and scoped.
    
    Refs: https://isocpp.org/wiki/faq/cpp11-language-types#enum-class
    deokjinkim committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    ff3020e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5d4cb6f View commit details
    Browse the repository at this point in the history
  3. Add k prefix to each element of enum

    This change is needed to fix error of window build.
    deokjinkim committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    b197bf1 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    574af27 View commit details
    Browse the repository at this point in the history