Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix test-timers-unrefd-interval-still-fires #4561

Closed
wants to merge 1 commit into from
Closed

test: fix test-timers-unrefd-interval-still-fires #4561

wants to merge 1 commit into from
+10 −11

Commits on Jan 11, 2016

  1. test: fix test-timers-unrefd-interval-still-fires 

    Remove arbitrary timeout duration. This is a functionality test and not
a performance benchmark. Rely on test runner timeout.

Confirmed that the test (with ES6-isms removed) hangs/times out in Node
0.10.34 (which has the bug that this test is supposed to catch) and
passes in 0.10.35 (which has the fix). So that is good.

Fixes: nodejs#4559
    @Trott
    Trott committed Jan 11, 2016
    Configuration menu
    Copy the full SHA
    13529be View commit details
    Browse the repository at this point in the history