crypto: update WebCryptoAPI WPT and related fixes #45569
Closed
+859
−157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panva
added
crypto
|
Review requested:
|
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
panva
force-pushed
the
webcrypto-wpt-bump
branch
from
afce4ea
to
c58018b
Compare
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
aduh95
reviewed
Nov 22, 2022
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
Is the order of commits correct? Shouldn't the commit that updates WTP come at the end after the fixes? |
It intentionally comes this way so that the fixes can cross of failing tests from the expectations file. |
aduh95
approved these changes
Nov 22, 2022
aduh95
added
the
author ready
This comment was marked as outdated.
This comment was marked as outdated.
16 tasks
danielleadams
pushed a commit
that referenced
this pull request
Jan 3, 2023
PR-URL: #45569 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 3, 2023
PR-URL: #45569 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 3, 2023
PR-URL: #45569 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 4, 2023
PR-URL: #45569 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 4, 2023
PR-URL: #45569 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 4, 2023
PR-URL: #45569 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 4, 2023
PR-URL: #45569 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 4, 2023
PR-URL: #45569 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 4, 2023
PR-URL: #45569 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 4, 2023
PR-URL: #45569 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 4, 2023
PR-URL: #45569 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 5, 2023
PR-URL: #45569 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 5, 2023
PR-URL: #45569 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 5, 2023
PR-URL: #45569 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 5, 2023
PR-URL: #45569 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 5, 2023
PR-URL: #45569 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 5, 2023
PR-URL: #45569 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 5, 2023
PR-URL: #45569 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 5, 2023
PR-URL: #45569 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
panva
added a commit
to panva/node
that referenced
this pull request
Mar 31, 2023
PR-URL: nodejs#45569 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Backport-PR-URL: nodejs#47336
panva
added a commit
to panva/node
that referenced
this pull request
Mar 31, 2023
PR-URL: nodejs#45569 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Backport-PR-URL: nodejs#47336
panva
added a commit
to panva/node
that referenced
this pull request
Mar 31, 2023
PR-URL: nodejs#45569 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Backport-PR-URL: nodejs#47336
panva
added a commit
to panva/node
that referenced
this pull request
Mar 31, 2023
PR-URL: nodejs#45569 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Backport-PR-URL: nodejs#47336
panva
added a commit
to panva/node
that referenced
this pull request
Mar 31, 2023
PR-URL: nodejs#45569 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Backport-PR-URL: nodejs#47336
panva
added a commit
to panva/node
that referenced
this pull request
Mar 31, 2023
PR-URL: nodejs#45569 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Backport-PR-URL: nodejs#47336
panva
added a commit
to panva/node
that referenced
this pull request
Mar 31, 2023
PR-URL: nodejs#45569 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Backport-PR-URL: nodejs#47336
panva
added a commit
to panva/node
that referenced
this pull request
Mar 31, 2023
PR-URL: nodejs#45569 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Backport-PR-URL: nodejs#47336
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the Chromium project is working on Ed25519 and X25519 implemenetation there are new WPTs being added. Mostly these are failure test vectors. Some of these fixes have also been applied to other algorithms where WPTs are currently lacking coverage.
I suggest to review individual commits, will land with commit-queue-rebaseAdd this label to allow the Commit Queue to land a PR in several commits.
.