build: add --v8-disable-object-print flag #45458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
richardlau
reviewed
Nov 14, 2022
| @@ -772,11 +772,11 @@ | |||
| 'memory footprint, but also implies no just-in-time compilation ' + | |||
| 'support, thus much slower execution)') | |||
|
|
|||
| parser.add_argument('--v8-enable-object-print', | |||
| parser.add_argument('--v8-disable-object-print', | |||
There was a problem hiding this comment.
We could keep --v8-enable-object-print as a valid option in addition to adding --v8-disable-object-print in case anyone is using it, otherwise they'll break
There was a problem hiding this comment.
Thanks for your suggestion, I keep the -v8-enable-object-print flag and add the --v8-disable-object-print flag.
If I specify both flags at the same time, We get an exception with a message like Only one of the --v8-enable-object-print or --v8-disable-object-print options an be specified at a time..
There was a problem hiding this comment.
I believe this introduced a bug? I cannot use "disable" flag because "enable" flag is default True, so if I "disable" then they're both True...
Downloading the source tarball on Nodejs' website for LTS 18.13.0 yields:
python3 ./configure --prefix=/opt/base --shared-zlib --v8-disable-object-print --without-corepack --without-dtrace --without-etw --without-inspector --without-intl --without-node-code-cache --without-node-snapshot --without-npm --without-ssl
Node.js configure: Found Python 3.9.10...
Traceback (most recent call last):
File "/Users/Hames/Repos/core/contrib/node-v18.13.0/./configure", line 28, in <module>
import configure
File "/Users/Hames/Repos/core/contrib/node-v18.13.0/configure.py", line 2062, in <module>
configure_v8(output)
File "/Users/Hames/Repos/core/contrib/node-v18.13.0/configure.py", line 1547, in configure_v8
raise Exception(
Exception: Only one of the --v8-enable-object-print or --v8-disable-object-print options can be specified at a time.
Even though the enable flag is never specified.
This is because the options object has the argparse defaults resolved, which means the enable flag is True if not specified... :/
parser.add_argument('--v8-enable-object-print',
action='store_true',
dest='v8_enable_object_print',
default=True, # HERE
help='compile V8 with auxiliary functions for native debuggers')
parser.add_argument('--v8-disable-object-print',
action='store_true',
dest='v8_disable_object_print',
default=False,
help='disable the V8 auxiliary functions for native debuggers')
configure.py
Outdated
| help='compile V8 with auxiliar functions for native debuggers') | ||
| dest='v8_disable_object_print', | ||
| default=False, | ||
| help='disable the V8 auxiliar functions for native debuggers') |
There was a problem hiding this comment.
Since we're editing this line, might as well fix this typo:
Suggested change
| help='disable the V8 auxiliar functions for native debuggers') | |
| help='disable the V8 auxiliary functions for native debuggers') |
There was a problem hiding this comment.
Thanks, I will fix typo.
--v8-enable-object-print flag is set by default true. so, no way of disable this flag. add a --v8-disable-object-print flag instead that defaults to false. Fixes: nodejs#45433
fossamagna
force-pushed
the
add-v8-disable-object-print-flag
branch
from
c041989
to
f50e2b4
Compare
joyeecheung
approved these changes
Nov 15, 2022
richardlau
approved these changes
Nov 15, 2022
github-actions
bot
removed
the
request-ci
richardlau
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 6638f09 |
ruyadorno
pushed a commit
that referenced
this pull request
Nov 21, 2022
--v8-enable-object-print flag is set by default true. so, no way of disable this flag. add a --v8-disable-object-print flag instead that defaults to false. Fixes: #45433 PR-URL: #45458 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Merged
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
--v8-enable-object-print flag is set by default true. so, no way of disable this flag. add a --v8-disable-object-print flag instead that defaults to false. Fixes: #45433 PR-URL: #45458 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Richard Lau <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
--v8-enable-object-print flag is set by default true. so, no way of disable this flag. add a --v8-disable-object-print flag instead that defaults to false. Fixes: #45433 PR-URL: #45458 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Richard Lau <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 3, 2023
--v8-enable-object-print flag is set by default true. so, no way of disable this flag. add a --v8-disable-object-print flag instead that defaults to false. Fixes: #45433 PR-URL: #45458 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Richard Lau <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 4, 2023
--v8-enable-object-print flag is set by default true. so, no way of disable this flag. add a --v8-disable-object-print flag instead that defaults to false. Fixes: #45433 PR-URL: #45458 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--v8-enable-object-printflag is set by default true. so, no way of disable this flag.remove
--v8-enable-object-printflag.add a
--v8-disable-object-printflag instead that defaults to false.Fixes: #45433