-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: typography mistake #45398
doc: typography mistake #45398
Conversation
Review requested:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a spelling mistake although it is awkward typography.
I don't know how to express it 😀. And thanks for immediately correcting my mistake. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have an official way of styling this? For example, (outside of nodejs docs) I write
require()
ed
import
ed
import()
ed
I've been looking for guidance in the Microsoft Style Guide (which we try to follow) but haven't found any. My personal opinion, though, is that we should avoid using function names as verbs.
For these reasons (and probably a few other reasons I haven't thought of), I think it's best to use a separate verb and let the function name be what it actually is, which is a noun. It might be good to standardize for some specific cases, though. This PR uses "included via |
I think it would be good to establish some kind of policy, otherwise we'll end up with a bunch of these issues/PRs. Colloquial English turns pretty much any word into a verb/past-participle by just adding "ed" to the end, so I think it's acceptable here. RE confusion about to what it's referring, that's why I include the parentheses: But I'm also totally fine with "included via |
Landed in c4d75ea |
PR-URL: #45398 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
PR-URL: #45398 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
PR-URL: #45398 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
PR-URL: #45398 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
PR-URL: #45398 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
No description provided.