Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: add loongarch64 into openssl Makefile and gen openssl-loongarch64 #45351

Closed
wants to merge 1 commit into from
Closed

deps: add loongarch64 into openssl Makefile and gen openssl-loongarch64 #45351

wants to merge 1 commit into from

Conversation

shipujin
Copy link
Member

@shipujin shipujin commented Nov 7, 2022

Add linux64-loongarch64 into Makefile
And run make

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. openssl Issues and PRs related to the OpenSSL dependency. labels Nov 7, 2022
@shipujin
Copy link
Member Author

shipujin commented Nov 7, 2022

There is a timeout error. How can i to re-trigger it ?

@anonrig
Copy link
Member

anonrig commented Nov 7, 2022

It's rebuilding now @shipujin

@targos
Copy link
Member

targos commented Nov 8, 2022

@nodejs/crypto

@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 10, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 10, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47823/

@github-actions github-actions bot mentioned this pull request Nov 11, 2022
Open
19 tasks
@shipujin
Copy link
Member Author

ping

@github-actions github-actions bot mentioned this pull request Nov 12, 2022
Open
19 tasks
This was referenced Nov 13, 2022
Open
Open
@shipujin
Copy link
Member Author

hello, I how do I need to resolve the "node-test-commit" failure item, thanks~

@shipujin
Copy link
Member Author

ping

@gengjiawen
Copy link
Member

You probably need to upstream this in: https://github.com/quictls/openssl

@shipujin
Copy link
Member Author

shipujin commented Nov 17, 2022 •
edited
Loading

You probably need to upstream this in:https://github.com/quictls/openssl

thanks~
I add LoongArch target to openssl/openssl [3.0]:openssl/openssl#18807
Add loongarch64 target: quictls/openssl: quictls/openssl@c09ce49

nodejs/deps/openssl: https://github.com/nodejs/node/blob/main/deps/openssl/openssl/Configurations/10-main.conf#L821

@shipujin
Copy link
Member Author

Friendly ping

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48068/

This was referenced Nov 22, 2022
Open
Open
Open
@shipujin
Copy link
Member Author

Friendly ping

@shipujin
Copy link
Member Author

Add linux64-loongarch64 into Makefile
And run make

@shipujin
Copy link
Member Author

shipujin commented Dec 1, 2022

@anonrig @targos @gengjiawen Sorry, I need to make any modifications,? thanks~
Add linux64-loongarch64 into Makefile

@shipujin shipujin closed this Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. openssl Issues and PRs related to the OpenSSL dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shipujin @anonrig @targos @nodejs-github-bot @gengjiawen