Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trace_events: add new categories #45266

Merged
merged 1 commit into from
Nov 19, 2022
Merged

trace_events: add new categories #45266

merged 1 commit into from
Nov 19, 2022

Conversation

theanarkh
Copy link
Contributor

add new categories.

Refs: #45092
Refs: #44458

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Nov 1, 2022
@theanarkh theanarkh added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 2, 2022
@github-actions github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Nov 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2022

Failed to start CI
- Validating Jenkins credentials
✖  Jenkins credentials invalid
https://github.com///actions/runs/3377836998

@theanarkh theanarkh added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Nov 2, 2022
@github-actions github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Nov 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2022

Failed to start CI
- Validating Jenkins credentials
✖  Jenkins credentials invalid
https://github.com///actions/runs/3378861038

@theanarkh theanarkh added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Nov 3, 2022
@github-actions github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Nov 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2022

Failed to start CI
- Validating Jenkins credentials
✖  Jenkins credentials invalid
https://github.com/nodejs/node/actions/runs/3387378766

@theanarkh theanarkh added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Nov 5, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 5, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47700/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47714/

@github-actions github-actions bot mentioned this pull request Nov 6, 2022
Open
18 tasks
@theanarkh theanarkh added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 6, 2022
This was referenced Nov 7, 2022
Open
Open
legendecas
legendecas approved these changes Nov 8, 2022
View reviewed changes
src/inspector/tracing_agent.cc Outdated Show resolved Hide resolved
@theanarkh theanarkh force-pushed the add_new_categories branch 2 times, most recently from 13d096d to 2509ae1 Compare November 8, 2022 17:34
@github-actions github-actions bot mentioned this pull request Nov 12, 2022
Open
19 tasks
@github-actions github-actions bot mentioned this pull request Nov 13, 2022
Open
25 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47902/

@github-actions github-actions bot mentioned this pull request Nov 14, 2022
Open
25 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47923/

@github-actions github-actions bot mentioned this pull request Nov 15, 2022
Open
23 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47940/

@github-actions github-actions bot mentioned this pull request Nov 16, 2022
Open
17 tasks
This was referenced Nov 17, 2022
Open
Open
Open
@theanarkh theanarkh added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 19, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 19, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48015/

@theanarkh theanarkh added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 19, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 19, 2022
@nodejs-github-bot nodejs-github-bot merged commit bcc704f into nodejs:main Nov 19, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in bcc704f

@github-actions github-actions bot mentioned this pull request Nov 20, 2022
Open
14 tasks
ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
@theanarkh @ruyadorno
trace_events: add new categories
f441b04 
PR-URL: #45266
Refs: #45092
Refs: #44458
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Nov 23, 2022
@theanarkh @marco-ippolito
trace_events: add new categories
1b53059 
PR-URL: nodejs#45266
Refs: nodejs#45092
Refs: nodejs#44458
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Nov 24, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@theanarkh @danielleadams
trace_events: add new categories
2275255 
PR-URL: #45266
Refs: #45092
Refs: #44458
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@theanarkh @danielleadams
trace_events: add new categories
a2256ba 
PR-URL: #45266
Refs: #45092
Refs: #44458
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@theanarkh @danielleadams
trace_events: add new categories
210cbcb 
PR-URL: #45266
Refs: #45092
Refs: #44458
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 4, 2023
@theanarkh @danielleadams
trace_events: add new categories
e83c5ee 
PR-URL: #45266
Refs: #45092
Refs: #44458
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 5, 2023
@theanarkh @danielleadams
trace_events: add new categories
31d2ce8 
PR-URL: #45266
Refs: #45092
Refs: #44458
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaisinTen RaisinTen RaisinTen approved these changes

@legendecas legendecas legendecas approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@theanarkh @nodejs-github-bot @jasnell @legendecas @RaisinTen