test: fix flaky test-cluster-shared-leak #4510
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
added
cluster
This was referenced Jan 1, 2016
Wait for worker2 to come online before doing anything that might result in an EPIPE. Fixes flakiness of test on Windows. Fixes: nodejs#3956
|
CI: https://ci.nodejs.org/job/node-test-pull-request/1131/ All green! \o/ |
|
Confirmed that the test still triggers an AssertionError in Node 4.2.1, so it still tests what it was originally written to test. |
|
Stress tests: With this fix, 9999 runs and no errors: https://ci.nodejs.org/job/node-stress-single-test/288/nodes=win2012r2-1p/console Without, 9999 runs and four errors: https://ci.nodejs.org/job/node-stress-single-test/289/nodes=win2012r2-1p/console |
|
LGTM |
1 similar comment
|
LGTM |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jan 4, 2016
Wait for worker2 to come online before doing anything that might result in an EPIPE. Fixes flakiness of test on Windows. Fixes: nodejs#3956 PR-URL: nodejs#4510 Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: James M Snell<[email protected]>
|
Landed in 063c9f6 |
Fishrock123
pushed a commit
to Fishrock123/node
that referenced
this pull request
Jan 6, 2016
Wait for worker2 to come online before doing anything that might result in an EPIPE. Fixes flakiness of test on Windows. Fixes: nodejs#3956 PR-URL: nodejs#4510 Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: James M Snell<[email protected]>
|
@Trott It looks like this is happening still, at least on win10 now: https://ci.nodejs.org/job/node-test-binary-windows/506/RUN_SUBSET=0,VS_VERSION=vs2015,label=win10/console |
|
@mscdex Unfortunately, yes. And unfortunately, I can't seem to replicate the failure in the stress test. Which is kind of troubling. Anyway, see #4476 (comment) and #4476 (comment) |
|
@Trott this one needs to be manually backported too :( |
|
@thealphanerd This will apply cleanly if you land #4421 first. |
MylesBorins
pushed a commit
that referenced
this pull request
Jan 28, 2016
Wait for worker2 to come online before doing anything that might result in an EPIPE. Fixes flakiness of test on Windows. Fixes: #3956 PR-URL: #4510 Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: James M Snell<[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 11, 2016
Wait for worker2 to come online before doing anything that might result in an EPIPE. Fixes flakiness of test on Windows. Fixes: #3956 PR-URL: #4510 Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: James M Snell<[email protected]>
MylesBorins
pushed a commit
to MylesBorins/node
that referenced
this pull request
Feb 11, 2016
Wait for worker2 to come online before doing anything that might result in an EPIPE. Fixes flakiness of test on Windows. Fixes: nodejs#3956 PR-URL: nodejs#4510 Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: James M Snell<[email protected]>
Merged
MylesBorins
pushed a commit
to MylesBorins/node
that referenced
this pull request
Feb 15, 2016
Wait for worker2 to come online before doing anything that might result in an EPIPE. Fixes flakiness of test on Windows. Fixes: nodejs#3956 PR-URL: nodejs#4510 Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: James M Snell<[email protected]>
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
Wait for worker2 to come online before doing anything that might result in an EPIPE. Fixes flakiness of test on Windows. Fixes: nodejs#3956 PR-URL: nodejs#4510 Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: James M Snell<[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wait for worker2 to come online before doing anything that might result
in an EPIPE. Fixes flakiness of test on Windows.
Fixes: #3956