report,doc: define report version semantics #45050

gireeshpunathil · 2022-10-18T07:35:40Z

Diagnostics report has a version number representing its format, yet its rule is not defined. This doc change specifies the rule.

Refs: nodejs/diagnostics#349
Refs: #28121 (comment)

/cc @nodejs/diagnostics

doc/api/report.md

mhdawson

LGTM

Diagnostics report has a version number representing its format, yet its rule is not defined. This doc change specifies the rule. Refs: nodejs/diagnostics#349 Refs: nodejs#28121 (comment)

nodejs-github-bot · 2022-10-21T06:56:06Z

Commit Queue failed

- Loading data for nodejs/node/pull/45050
FetchError: Invalid response body while trying to fetch https://api.github.com/graphql: Premature close
    at consumeBody (file:///opt/hostedtoolcache/node/16.17.1/x64/lib/node_modules/node-core-utils/node_modules/node-fetch/src/body.js:234:60)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async Response.text (file:///opt/hostedtoolcache/node/16.17.1/x64/lib/node_modules/node-core-utils/node_modules/node-fetch/src/body.js:158:18)
    at async Request.json (file:///opt/hostedtoolcache/node/16.17.1/x64/lib/node_modules/node-core-utils/lib/request.js:51:18)
    at async Request.query (file:///opt/hostedtoolcache/node/16.17.1/x64/lib/node_modules/node-core-utils/lib/request.js:109:20)
    at async Request.queryAll (file:///opt/hostedtoolcache/node/16.17.1/x64/lib/node_modules/node-core-utils/lib/request.js:136:20)
    at async Request.gql (file:///opt/hostedtoolcache/node/16.17.1/x64/lib/node_modules/node-core-utils/lib/request.js:66:22)
    at async PRData.getComments (file:///opt/hostedtoolcache/node/16.17.1/x64/lib/node_modules/node-core-utils/lib/pr_data.js:97:21)
    at async Promise.all (index 2)
    at async Promise.all (index 1) {
  type: 'system',
  errno: 'ERR_STREAM_PREMATURE_CLOSE',
  code: 'ERR_STREAM_PREMATURE_CLOSE',
  erroredSysCall: undefined
}

https://github.com/nodejs/node/actions/runs/3295384782

gireeshpunathil · 2022-10-21T07:05:15Z

commit queue failed with this error:

FetchError: Invalid response body while trying to fetch https://api.github.com/graphql: Premature close

not sure what this means. any idea?

legendecas · 2022-10-21T09:02:15Z

I assume it is a network issue. Re-applying the commit queue.

nodejs-github-bot · 2022-10-21T09:11:35Z

Commits were pushed since the last review.

Commit Queue failed

- Loading data for nodejs/node/pull/45050
✔  Done loading data for nodejs/node/pull/45050
----------------------------------- PR info ------------------------------------
Title      report,doc: define report version semantics (#45050)
Author     Gireesh Punathil  (@gireeshpunathil)
Branch     gireeshpunathil:report-version -> nodejs:main
Labels     doc, author ready, report
Commits    1
 - report,doc: define report version semantics
Committers 1
 - Gireesh Punathil 
PR-URL: https://github.com/nodejs/node/pull/45050
Refs: https://github.com/nodejs/diagnostics/issues/349
Reviewed-By: Rafael Gonzaga 
Reviewed-By: Richard Lau 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Chengzhong Wu 
Reviewed-By: Michael Dawson 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/45050
Refs: https://github.com/nodejs/diagnostics/issues/349
Reviewed-By: Rafael Gonzaga 
Reviewed-By: Richard Lau 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Chengzhong Wu 
Reviewed-By: Michael Dawson 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last review:
   ⚠  - report,doc: define report version semantics
   ℹ  This PR was created on Tue, 18 Oct 2022 07:35:40 GMT
   ✔  Approvals: 6
   ✔  - Rafael Gonzaga (@RafaelGSS): https://github.com/nodejs/node/pull/45050#pullrequestreview-1145656434
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/45050#pullrequestreview-1145697102
   ✔  - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/45050#pullrequestreview-1146224600
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/45050#pullrequestreview-1148302093
   ✔  - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/45050#pullrequestreview-1148701611
   ✔  - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/45050#pullrequestreview-1150061838
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/3296201433

nodejs-github-bot · 2022-10-21T09:29:16Z

Landed in c127e4e

Diagnostics report has a version number representing its format, yet its rule is not defined. This doc change specifies the rule. Refs: nodejs/diagnostics#349 Refs: #28121 (comment) PR-URL: #45050 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Michael Dawson <[email protected]>

nodejs-github-bot added doc Issues and PRs related to the documentations. report Issues and PRs related to process.report. labels Oct 18, 2022

richardlau reviewed Oct 18, 2022

View reviewed changes

doc/api/report.md Show resolved Hide resolved

RafaelGSS approved these changes Oct 18, 2022

View reviewed changes

richardlau approved these changes Oct 18, 2022

View reviewed changes

cjihrig reviewed Oct 18, 2022

View reviewed changes

doc/api/report.md Outdated Show resolved Hide resolved

cjihrig approved these changes Oct 18, 2022

View reviewed changes

legendecas reviewed Oct 18, 2022

View reviewed changes

doc/api/report.md Show resolved Hide resolved

jasnell approved these changes Oct 19, 2022

View reviewed changes

legendecas approved these changes Oct 20, 2022

View reviewed changes

mhdawson approved these changes Oct 20, 2022

View reviewed changes

report,doc: define report version semantics

790a8b2

Diagnostics report has a version number representing its format, yet its rule is not defined. This doc change specifies the rule. Refs: nodejs/diagnostics#349 Refs: nodejs#28121 (comment)

gireeshpunathil force-pushed the report-version branch from 2aabc8d to 790a8b2 Compare October 21, 2022 03:40

gireeshpunathil added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 21, 2022

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 21, 2022

legendecas added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Oct 21, 2022

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 21, 2022

legendecas approved these changes Oct 21, 2022

View reviewed changes

legendecas added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Oct 21, 2022

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 21, 2022

nodejs-github-bot merged commit c127e4e into nodejs:main Oct 21, 2022

gireeshpunathil mentioned this pull request Oct 21, 2022

reportVersion semantics are not defined nodejs/diagnostics#349

Closed

RafaelGSS mentioned this pull request Nov 1, 2022

v19.1.0 proposal #45269

Merged

danielleadams mentioned this pull request Dec 30, 2022

v18.13.0 release proposal #46025

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

report,doc: define report version semantics #45050

report,doc: define report version semantics #45050

gireeshpunathil commented Oct 18, 2022

mhdawson left a comment

nodejs-github-bot commented Oct 21, 2022

gireeshpunathil commented Oct 21, 2022

legendecas commented Oct 21, 2022

nodejs-github-bot commented Oct 21, 2022 •

edited by legendecas

Loading

nodejs-github-bot commented Oct 21, 2022

report,doc: define report version semantics #45050

report,doc: define report version semantics #45050

Conversation

gireeshpunathil commented Oct 18, 2022

mhdawson left a comment

Choose a reason for hiding this comment

nodejs-github-bot commented Oct 21, 2022

gireeshpunathil commented Oct 21, 2022

legendecas commented Oct 21, 2022

nodejs-github-bot commented Oct 21, 2022 • edited by legendecas Loading

nodejs-github-bot commented Oct 21, 2022

nodejs-github-bot commented Oct 21, 2022 •

edited by legendecas

Loading