lib: add options to the heap snapshot APIs #44989
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
joyeecheung
commented
Oct 13, 2022
| --> | ||
|
|
||
| * `options` {Object} | ||
| * `exposeInternals` {boolean} If true, expose internals in the heap snapshot. |
There was a problem hiding this comment.
I am actually not sure if we should use constants (e.g. strings) for these, suggestions are welcome. Also AFAIK exposeInternals doesn't currently change anything for us because we don't use any embedder tracing mechanism provided by V8 that could would make a difference here, but this might change in the future.
joyeecheung
commented
Oct 13, 2022
aduh95
reviewed
Oct 13, 2022
aduh95
reviewed
Oct 13, 2022
jasnell
reviewed
Oct 16, 2022
jasnell
reviewed
Oct 16, 2022
jasnell
reviewed
Oct 16, 2022
jasnell
reviewed
Oct 16, 2022
jasnell
reviewed
Oct 16, 2022
addaleax
approved these changes
Oct 25, 2022
Support configuration of the HeapSnapshotMode and NumericsMode fields inf HeapSnapshotOptions in the JS APIs for heap snapshots.
joyeecheung
force-pushed
the
heapsnapshot-options
branch
from
f9c375e
to
cbe5987
Compare
legendecas
approved these changes
Oct 31, 2022
17 tasks
joyeecheung
commented
Nov 1, 2022
| const { | ||
| exposeInternals = false, | ||
| exposeNumericValues = false, | ||
| } = options; |
15 tasks
17 tasks
joyeecheung
added a commit
that referenced
this pull request
Nov 8, 2022
Support configuration of the HeapSnapshotMode and NumericsMode fields inf HeapSnapshotOptions in the JS APIs for heap snapshots. PR-URL: #44989 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
|
Landed in b872d30 |
14 tasks
lucshi
pushed a commit
to lucshi/node
that referenced
this pull request
Nov 9, 2022
Support configuration of the HeapSnapshotMode and NumericsMode fields inf HeapSnapshotOptions in the JS APIs for heap snapshots. PR-URL: nodejs#44989 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
20 tasks
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 10, 2022
Support configuration of the HeapSnapshotMode and NumericsMode fields inf HeapSnapshotOptions in the JS APIs for heap snapshots. PR-URL: #44989 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
Merged
19 tasks
danielleadams
added
the
backport-requested-v18.x
|
@joyeecheung this broke when landing in v18.x-staging. Do you mind opening a backport PR for this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support configuration of the HeapSnapshotMode and NumericsMode fields inf HeapSnapshotOptions in the JS APIs for heap snapshots.