Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: simplify webcrypto ECDH deriveBits #44946

Merged
merged 1 commit into from
Oct 12, 2022
Merged

crypto: simplify webcrypto ECDH deriveBits #44946

merged 1 commit into from
Oct 12, 2022

Conversation

panva
Copy link
Member

@panva panva commented Oct 10, 2022

This refactors webcrypto's ECDH deriveBits operation used by the ECDH, X25519, and X448 algorithms.

@panva panva added crypto Issues and PRs related to the crypto subsystem. webcrypto labels Oct 10, 2022
@panva panva requested a review from jasnell October 10, 2022 08:36
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto

@panva panva added the experimental Issues and PRs related to experimental features. label Oct 10, 2022
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Oct 10, 2022
@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 10, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 10, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47147/

@panva panva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 10, 2022
@panva panva mentioned this pull request Oct 12, 2022
Merged
@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 12, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 12, 2022
@nodejs-github-bot nodejs-github-bot merged commit eeec3eb into nodejs:main Oct 12, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in eeec3eb

@panva panva deleted the webcrypto-refactor-derivebits branch October 13, 2022 09:12
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@panva @danielleadams
crypto: simplify webcrypto ECDH deriveBits
63df516 
PR-URL: #44946
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@panva @danielleadams
crypto: simplify webcrypto ECDH deriveBits
631421e 
PR-URL: #44946
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@aduh95 aduh95 aduh95 approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. crypto Issues and PRs related to the crypto subsystem. experimental Issues and PRs related to experimental features. needs-ci PRs that need a full CI run. webcrypto
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@panva @nodejs-github-bot @jasnell @aduh95 @RafaelGSS