module: migrate to script context based host defined options #44923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
needs-ci
|
I'm beyond happy to see movement on this issue more than a year and a half after it was pointed to as a blocker of stabilization of vm ESM 🎉 |
|
Can this PR get landed before the v8 team decides to adopt your change? @legendecas |
|
@ywave620 that's not in accord with the working process. I don't think we should land this before the v8 CL gets landed first. |
|
@legendecas What's the status on the V8 side? |
|
@targos thanks for the ping. I'll reach out to Camillo to see the next steps. |
This allows the host-defined options to be an arbitrary JavaScript value so that the module/script wrapper object can be used as the host-defined options instead. In this way, we can move away from the id-based module tables and fixes the problem that the scripts can out lives the module wrapper objects.
legendecas
force-pushed
the
vm/host-defined-options
branch
from
54f0d90
to
438df3b
Compare
|
#48510 fixed the crashes with an alternative approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not ready to be reviewed properly. Just a preview of the solution.
deps: v8: [runtime] Store host-defined options in the context
CR-URL: https://chromium-review.googlesource.com/c/v8/v8/+/3172764
module: migrate to script context based host defined options
This allows the host-defined options to be an arbitrary JavaScript value
so that the module/script wrapper object can be used as the host-defined
options instead. In this way, we can move away from the id-based module
tables and fixes the problem that the scripts can out lives the module
wrapper objects.
Fixes: #43681
Fixes: #43205
Fixes: #44438