Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v14.21.0 proposal #44889

Merged
merged 16 commits into from
Nov 1, 2022
Merged

v14.21.0 proposal #44889

merged 16 commits into from
Nov 1, 2022

Conversation

danielleadams
Copy link
Contributor

@danielleadams danielleadams commented Oct 4, 2022

2022-11-01, Version 14.21.0 'Fermium' (LTS), @danielleadams

Notable changes

  • deps:
    • update corepack to 0.14.2 (Node.js GitHub Bot) #44775
  • src:
    • add --openssl-shared-config option (Daniel Bevenius) #43124

Commits

danbev and others added 9 commits September 23, 2022 11:02
This commit adds a new command line option named
'--openssl-shared-config' intended to allow reverting to the old OpenSSL
configuration behavior where Node.js would use the configuration section
name (called appname in OpenSSL) 'openssl_conf' which could potentially
be used my other applications..

PR-URL: #43124
Refs: #40366
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Backport-PR-URL: #43782

Refs: nodejs/nodejs.org#4713
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
PR-URL: #43402
Backport-PR-URL: #43760
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
PR-URL: #43748
Backport-PR-URL: #43760
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
PR-URL: #43965
Backport-PR-URL: #43760
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Mestery <[email protected]>
PR-URL: #44159
Backport-PR-URL: #43760
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Feng Yu <[email protected]>
PR-URL: #44229
Backport-PR-URL: #43760
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Feng Yu <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
PR-URL: #44318
Backport-PR-URL: #43760
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #44509
Backport-PR-URL: #43760
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Feng Yu <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #44704
Backport-PR-URL: #43760
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. v14.x labels Oct 4, 2022
danielleadams added a commit that referenced this pull request Oct 4, 2022
Notable changes:

* deps:
  * update corepack to 0.14.1 (Node.js GitHub Bot) #44704
* src:
  * add --openssl-shared-config option (Daniel Bevenius) #43124

PR-URL: #44889
@nodejs-github-bot
Copy link
Collaborator

danielleadams added a commit that referenced this pull request Oct 5, 2022
Notable changes:

* deps:
  * update corepack to 0.14.1 (Node.js GitHub Bot) #44704
* src:
  * add --openssl-shared-config option (Daniel Bevenius) #43124

PR-URL: #44889
@nodejs-github-bot
Copy link
Collaborator

@VoltrexKeyva VoltrexKeyva added release Issues and PRs related to Node.js releases. and removed meta Issues and PRs related to the general management of the project. dependencies Pull requests that update a dependency file. labels Oct 5, 2022
@danielleadams
Copy link
Contributor Author

I forgot to update the commit date. I'll do that.

@juanarbol
Copy link
Member

I forgot to update the commit date. I'll do that.

Gracias Danielle!

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 10, 2022

@richardlau
Copy link
Member

We could potentially include

richardlau and others added 5 commits October 24, 2022 19:08
PR-URL: #45094
Refs: nodejs/Release#773
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Danielle Adams <[email protected]>
PR-URL: #44775
Backport-PR-URL: #44924
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Refs: #43929 (comment)

PR-URL: #43954
Backport-PR-URL: #45126
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Feng Yu <[email protected]>
Original commit log follows:

darwin: remove EPROTOTYPE error workaround (libuv/libuv#3405)

It's been reported in the past that OS X 10.10, because of a race
condition in the XNU kernel, sometimes returns a transient EPROTOTYPE
error when trying to write to a socket. Libuv handles that by retrying
the operation until it succeeds or fails with a different error.

Recently it's been reported that current versions of the operating
system formerly known as OS X fail permanently with EPROTOTYPE under
certain conditions, resulting in an infinite loop.

Because Apple isn't exactly forthcoming with bug fixes or even details,
I'm opting to simply remove the workaround and have the error bubble up.

Refs: libuv/libuv#482
Fixes: #43916

PR-URL: #43950
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Original commit log follows:

darwin: translate EPROTOTYPE to ECONNRESET (libuv/libuv#3413)

macOS versions 10.10 and 10.15 - and presumbaly 10.11 to 10.14, too -
have a bug where a race condition causes the kernel to return EPROTOTYPE
because the socket isn't fully constructed.

It's probably the result of the peer closing the connection and that is
why libuv translates it to ECONNRESET.

Previously, libuv retried until the EPROTOTYPE error went away but some
VPN software causes the same behavior except the error is permanent, not
transient, turning the retry mechanism into an infinite loop.

Refs: libuv/libuv#482
Refs: libuv/libuv#3405
Fixes: #43916

PR-URL: #43950
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@richardlau
Copy link
Member

danielleadams added a commit that referenced this pull request Nov 1, 2022
Notable changes:

* deps:
  * update corepack to 0.14.2 (Node.js GitHub Bot) #44775
* src:
  * add --openssl-shared-config option (Daniel Bevenius) #43124

PR-URL: #44889
aduh95 and others added 2 commits November 1, 2022 00:37
PR-URL: #41939
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Notable changes:

* deps:
  * update corepack to 0.14.2 (Node.js GitHub Bot) #44775
* src:
  * add --openssl-shared-config option (Daniel Bevenius) #43124

PR-URL: #44889
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 1, 2022

@nodejs-github-bot
Copy link
Collaborator

danielleadams added a commit that referenced this pull request Nov 1, 2022
@danielleadams danielleadams merged commit f7e5f28 into v14.x Nov 1, 2022
@danielleadams danielleadams deleted the v14.21.0-proposal branch November 1, 2022 21:18
danielleadams added a commit that referenced this pull request Nov 1, 2022
Notable changes:

* deps:
  * update corepack to 0.14.2 (Node.js GitHub Bot) #44775
* src:
  * add --openssl-shared-config option (Daniel Bevenius) #43124

PR-URL: #44889
danielleadams added a commit to nodejs/nodejs.org that referenced this pull request Nov 1, 2022
danielleadams added a commit to nodejs/nodejs.org that referenced this pull request Nov 1, 2022
lucshi pushed a commit to lucshi/node that referenced this pull request Nov 9, 2022
Notable changes:

* deps:
  * update corepack to 0.14.2 (Node.js GitHub Bot) nodejs#44775
* src:
  * add --openssl-shared-config option (Daniel Bevenius) nodejs#43124

PR-URL: nodejs#44889
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. release Issues and PRs related to Node.js releases.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants