Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: remove node_bob.h and node_bob-inl.h #44607

Closed
wants to merge 1 commit into from

Conversation

RaisinTen
Copy link
Contributor

These were added in #32379 and were supposed to get removed in #37067.

Signed-off-by: Darshan Sen [email protected]

cc @jasnell

These were added in nodejs#32379 and were
supposed to get removed in nodejs#37067.

Signed-off-by: Darshan Sen <[email protected]>
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Sep 12, 2022
@nodejs-github-bot

This comment was marked as outdated.

@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 12, 2022
@tniessen
Copy link
Member

tniessen commented Sep 12, 2022

Just want to make sure this is not going to make James' work more difficult in #44325... cc @jasnell. (There's also a few leftovers in the crypto code base that I have not removed yet because they might still be needed for the upcoming QUIC implementation.)

Looks like these files are required for that PR and would just be re-added. Maybe we should wait with removing more prerequisites of #44325.

@nodejs-github-bot
Copy link
Collaborator

Copy link
Member

@tniessen tniessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just making my concern explicit. I don't think we should be removing this while the new QUIC PR depends on these files. It's already a ton of work for James and re-adding files with no changes just seems to add to it.

That's just my take though and I'm only requesting changes so that this point is not missed. If someone believes this should land regardless, I'll gladly dismiss my review.

@RaisinTen RaisinTen removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 18, 2022
@RaisinTen
Copy link
Contributor Author

That was an oversight on my part. I have no intentions of making James' work more difficult, closing. :)

@RaisinTen RaisinTen closed this Sep 18, 2022
@RaisinTen RaisinTen deleted the src/remove-node_bob branch September 18, 2022 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants