-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: mention that http.Server inherits from net.Server #4455
Conversation
Maybe we can just drop the "This is an EventEmitter" part since the docs for This class inherits from |
cea2aa6
to
c69dd56
Compare
c69dd56
to
005a6f1
Compare
LGTM. Can you update the commit message according to https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#step-3-commit. |
005a6f1
to
97117d0
Compare
Done. And thanks for the link. |
LGTM |
3 similar comments
LGTM |
LGTM |
LGTM |
PR-URL: #4455 Reviewed-By: Brian White <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: James M Snell <[email protected]>
Landed in 4e8a005 |
Thanks for the contribution @ryansobol! I believe this is your first commit to core and I see a few other PRs from you as well, it's great to see you jumping right in. Please holler if you need any help landing your other work. I hope you continue to find ways to contribute and stick around. |
PR-URL: nodejs#4455 Reviewed-By: Brian White <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #4455 Reviewed-By: Brian White <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #4455 Reviewed-By: Brian White <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: nodejs#4455 Reviewed-By: Brian White <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: nodejs#4455 Reviewed-By: Brian White <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: nodejs#4455 Reviewed-By: Brian White <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: James M Snell <[email protected]>
As a Node beginner, it wasn't immediately obvious to me that
http.Server
inherits fromnet.Server
until I read the source.