doc: improvements to errors.markdown copy #4454
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| - JavaScript errors caused by improper JavaScript language syntax | ||
| ([`SyntaxError`][]), use of undefined variables ([`ReferenceError`][]), | ||
| passing arguments of the wrong type ([`TypeError`][]), and so on; |
There was a problem hiding this comment.
and so on here is a bit non-descriptive for documentation. If there are other JavaScript errors we should likely list them right?
|
LGTM with a few small nits |
|
👍 to the nits @thealphanerd mentioned. After those are resolved, I'd say LGTM too. |
General improvements to errors.markdown including improved/revised examples
jasnell
force-pushed
the
doc-errors-improvements
branch
from
31716d0
to
ab658f4
Compare
|
@Qard @thealphanerd ... nits addressed. |
|
LGTM |
jasnell
added a commit
that referenced
this pull request
Jan 4, 2016
General improvements to errors.markdown including improved/revised examples PR-URL: #4454 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
|
Landed in bbb4a2a |
Fishrock123
pushed a commit
to Fishrock123/node
that referenced
this pull request
Jan 6, 2016
General improvements to errors.markdown including improved/revised examples PR-URL: nodejs#4454 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 13, 2016
General improvements to errors.markdown including improved/revised examples PR-URL: #4454 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 19, 2016
General improvements to errors.markdown including improved/revised examples PR-URL: #4454 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
Merged
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
General improvements to errors.markdown including improved/revised examples PR-URL: nodejs#4454 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General improvements to errors.markdown including
improved/revised examples