Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: add extra CA certs to all secure contexts #44529

Closed

Commits on Jul 26, 2024

  1. crypto: add extra CA certs to all secure contexts

    Store loaded NODE_EXTRA_CA_CERTS into root_certs_vector, allowing
    them to be added to secure contexts when NewRootCertStore() is
    called.
    
    When NODE_EXTRA_CA_CERTS is specified, the root certificates
    (both bundled and extra) will no longer be preloaded at startup.
    This improves Node.js startup time and makes the behavior of
    NODE_EXTRA_CA_CERTS consistent with the default behavior when
    NODE_EXTRA_CA_CERTS is omitted.
    
    The original reason NODE_EXTRA_CA_CERTS were loaded at startup
    (issues nodejs#20432, nodejs#20434) was to prevent the environment variable from
    being changed at runtime. This change preserves the runtime consistency
    without actually having to load the certs at startup.
    
    Fixes: nodejs#32010
    Refs: nodejs#40524
    Refs: nodejs#23354
    ebickle committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    61b1f13 View commit details
    Browse the repository at this point in the history