doc: improvements to domain.markdown copy #4451
Conversation
jasnell
added
doc
|
@nodejs/documentation @misterdjules |
| will be notified, rather than losing the context of the error in the | ||
| `process.on('uncaughtException')` handler, or causing the program to | ||
| exit immediately with an error code. | ||
| the functionality provided by the `domain` modules may rely on it for the |
|
Some minor nits, but LGTM when those are addressed. |
General improvements to the domain.markdown copy including improved examples.
jasnell
force-pushed
the
doc-domain-improvements
branch
from
b85972d
to
c2ca566
Compare
|
@Qard ... fixed! |
| For instance, in the example `cluster` application below, worker processes | ||
| are intentionally written to randomly throw errors. When these occur, the | ||
| worker process shuts down immediately, leading to an ungraceful exit of the | ||
| master process: |
There was a problem hiding this comment.
It might help to mention why the master process exits with an error in this case. Unless readers are familiar with the cluster module, it's not crystal clear.
|
@jasnell Thank you for doing that! I'm not a fan of having the first/only examples tied to using the Once the rest of my comments are addressed I'll take another look, but this already looks like a great improvement. |
|
@misterdjules .. thanks for the comments! I'll update shortly |
estliberitas
force-pushed
the
master
branch
2 times, most recently
from
7da4fd4
to
c7066fb
Compare
General improvements to the domain.markdown copy including
improved examples.