Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix flaky cluster-net-send #4444

Closed

Commits on Dec 29, 2015

  1. test: fix flaky cluster-net-send

    Before this commit, it was possible on Windows for the server's
    'connection' handler to be called *after* the client socket's
    'connect' handler. This caused the 'message' event to be missed
    and the test would never end (timing out in CI). This problem
    was more easily reproducible on a low resource (slow CPU)
    Windows (2012r2) installation.
    
    This commit waits until both handlers have been called before
    sending the handle to the master process.
    
    Fixes: nodejs#3957
    PR-URL: nodejs#4444
    mscdex committed Dec 29, 2015
    Configuration menu
    Copy the full SHA
    0fb7ef2 View commit details
    Browse the repository at this point in the history