Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: raise sleep times in child process tests #44375

Merged
merged 1 commit into from
Aug 25, 2022

Commits on Aug 24, 2022

  1. test: raise sleep times in child process tests

    sequential/test-child-process-execsync and
    parallel/test-child-process-spawnsync-timeout are both flaky
    on azure Windows machines, where it may take longer for Node.js
    to launch and receive output from child processes. These tests
    work by spawning a child processes that is supposed to sleep
    for a long time, but the option is configured so that Node.js
    would terminate them early when a shorter timeout is reached.
    Then the tests assert that the time taken for the whole thing
    is shorter than the specified sleep time (meaning the process
    don't actually get to sleep for that long). To make the tests
    less brittle on azure Windows, this patch raises the sleep
    times in those tests on Windows platform, so that the overhead
    can be taken into account there.
    joyeecheung committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    3647472 View commit details
    Browse the repository at this point in the history