Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v18.8.0 release proposal #44353

Merged
merged 177 commits into from
Aug 24, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
177 commits
Select commit Hold shift + click to select a range
68ee8e9
src: split property helpers from node::Environment
legendecas Aug 1, 2022
8c2d19b
http: do not leak error listeners
ShogunPanda Jun 27, 2022
e072c3a
esm: move package config helpers
GeoffreyBooth Jul 26, 2022
1175d90
tools: add verbose flag to find-inactive-collaborators
Trott Jul 26, 2022
7af55db
doc: add missing test runner option
MoLow Jul 26, 2022
3c8037a
test: change misleading variable name
tniessen Jul 26, 2022
1b32830
doc: fix typos in `test.md`
aduh95 Jul 26, 2022
9244d6d
test: fix test-cluster-concurrent-disconnect
daeyeon Jul 26, 2022
2cab7bb
test: reduce loop times for preventing test from timeout
theanarkh Jul 26, 2022
51a0310
test_runner: validate `concurrency` option
aduh95 Jul 26, 2022
b6b632c
net: add local family
theanarkh Jul 26, 2022
d964b30
test: remove test-gc-http-client-timeout from flaky list
F3n67u Jul 26, 2022
a0c5783
deps: cherry-pick 00704f5a from V8 upstream
kvakil Jul 26, 2022
94912bb
lib: add `Promise` methods to `avoid-prototype-pollution` lint rule
aduh95 Jul 26, 2022
72a9ecf
doc: fix typo in packages.md
jtoar Jul 27, 2022
04fdc3e
test_runner: graceful termination on `--test` only
MoLow Jul 27, 2022
5dc39a1
http: reuse socket only when it is drained
ywave620 Jul 27, 2022
4603977
src: remove unnecessary cast in crypto_sig.cc
tniessen Jul 27, 2022
374b776
doc: list supported MODP groups explicitly
tniessen Jul 27, 2022
4249276
src,lib: print source map error source on demand
legendecas Jul 28, 2022
617ea4a
lib: add missing env vars to --help
cola119 Jun 19, 2022
222ecd6
doc: add missing env vars to man page
cola119 Jun 19, 2022
d23dfa4
doc: remove old reference from crypto/README.md
tniessen Jul 27, 2022
9763e2f
src: fix typo in src/README.md
addaleax Jul 27, 2022
50c854b
test_runner: fix top level `describe` queuing
MoLow Jul 28, 2022
b7aaf3d
deps: upgrade npm to 8.15.1
npm-cli-bot Jul 28, 2022
cc6e0fc
src: improve SPKAC::ExportChallenge()
tniessen Jul 28, 2022
728e18e
src: fix to use replacement character
cola119 Jul 29, 2022
b19564b
test: refactor ESM tests to improve performance
JakobJingleheimer Jul 29, 2022
a2cd8b3
http: make idle http parser count configurable
theanarkh Jul 29, 2022
ecf8218
src,fs: refactor duplicated code in fs.readdir
daeyeon Jul 29, 2022
697dbfb
meta: shorten PowerShell snippet for bug-report template
NicoNekoru Jul 27, 2022
b90b8ab
src: fix bug in GetErrorSource()
tniessen Jul 28, 2022
1b9537b
doc: claim ABI version for Electron 21
VerteDinde Jul 30, 2022
2ae5d85
doc: fix code examples in `crypto.md`
aduh95 Jul 30, 2022
c3fa82f
test_runner: add before/after/each hooks
MoLow Jun 30, 2022
04bcdf6
src: use a typed array internally for process._exiting
RaisinTen Jul 31, 2022
7f7a0eb
doc: clarify part of onboarding guide regarding adding to teams
RaisinTen Jul 31, 2022
3eacf25
tools: update lint-md-dependencies to [email protected]
nodejs-github-bot Jul 31, 2022
40e2ca7
test: fix `internet/test-inspector-help-page`
daeyeon Jul 31, 2022
1d6029a
doc: add kvakil to triagers
kvakil Jul 31, 2022
0d00747
test_runner: empty pending tests queue post running
MoLow Jul 31, 2022
76011dd
doc: copyedit `test.md`
aduh95 Jul 31, 2022
ea48c56
build: skip test-internet run on forks
Trott Jul 31, 2022
3ba75b3
net,tls: pass a valid socket on `tlsClientError`
daeyeon Aug 1, 2022
fe83d51
doc: update collaborator email
ruyadorno Aug 1, 2022
58f2739
doc: add ErickWendel to collaborators
ErickWendel Aug 1, 2022
a996f53
meta: update AUTHORS
nodejs-github-bot Aug 2, 2022
d8749c3
test_runner: verbous error when entire test tree is canceled
MoLow Aug 2, 2022
ec1b31e
build: allow test-internet on forks if not scheduled
Trott Aug 2, 2022
c4783e3
src: nest namespace report in namespace node
legendecas Jul 31, 2022
38cdb1f
src: remove usages of GetBackingStore in startup
kvakil Aug 3, 2022
a54e4d4
src: remove usages of GetBackingStore in WASI
kvakil Aug 3, 2022
cddf3ed
src: remove usages of GetBackingStore in modules
kvakil Aug 3, 2022
8e1b7e2
src: remove usages of GetBackingStore in node-api
kvakil Aug 3, 2022
a2022e5
src: remove unowned usages of GetBackingStore
kvakil Aug 3, 2022
e0efd9a
meta: add codeowner for src/node_snapshot*
legendecas Aug 3, 2022
1dabdbf
src,test: fix typos
sadikkuzu Aug 3, 2022
0223603
doc: update repository list in onboarding doc
Trott Aug 3, 2022
46f8fb8
doc: clarify tls.tlsSocket.getCipher().version
AdamMajer Aug 3, 2022
c3d8756
net, dns: socket should handle its output as input
AdamMajer Aug 3, 2022
9990dc7
src,buffer: remove unused chars_written parameter
kvakil Aug 4, 2022
8ed3939
test_runner: refactor to use more primordials
aduh95 Aug 4, 2022
da7bc5a
doc,worker: deprecate `--trace-atomics-wait`
kvakil Aug 4, 2022
8c26daf
doc: add theanarkh to collaborators
theanarkh Aug 4, 2022
116dccc
deps: upgrade base64 to dc6a41ce36e
mscdex Jul 28, 2022
e7d101f
bootstrap: support more builtins in the embedded code cache
joyeecheung Jul 28, 2022
5e9c197
esm: fix loader hooks accepting too many arguments
JakobJingleheimer Aug 4, 2022
cb7a9e7
doc: remove unused code in call tracker example
cjihrig Aug 4, 2022
123b2d6
bootstrap: turn on FunctionCodeHandling::kKeep in the snapshot builder
joyeecheung Aug 4, 2022
2f904bc
stream: update TextEncoderStream to align the latest spec
cola119 Aug 4, 2022
4755ad5
src: remove usages of GetBackingStore in crypto
kvakil Aug 4, 2022
05802c2
module: protect against prototype mutation
aduh95 Aug 4, 2022
c02bbdd
lib: pass env variables to child process on z/OS
alexcfyung Mar 8, 2022
194587e
deps: upgrade npm to 8.16.0
npm-cli-bot Aug 5, 2022
763b956
deps: remove unnecessary file
mscdex Aug 5, 2022
86bbd5e
test: tune down parallelism for some flaky tests
kvakil Aug 5, 2022
c340344
http: trace http request / response
theanarkh Aug 5, 2022
52a516a
deps: V8: cherry-pick 9861ce1deae2
miladfarca Aug 3, 2022
960a209
src: prevent copying ArrayBufferViewContents
kvakil Aug 6, 2022
b252f38
tools: update undici CPE in vuln checking script
facutuesca Aug 6, 2022
ee6412a
src,lib: print prinstine source when source map source not found
legendecas Aug 6, 2022
fb11643
doc: add performance note to `--enable-source-maps` docs
saurabhdaware Aug 6, 2022
f1b5f93
test: s390x z15 accelerated zlib fixes
AdamMajer Aug 6, 2022
0fffc24
doc: add Retry CI in collaborator guide
LiviaMedeiros Aug 6, 2022
c975c4f
build: optimized and fixed building configuration to Android
MeowShe Aug 7, 2022
e5113fa
test: remove test-http-client-response-timeout flaky designation
lpinca Aug 7, 2022
e17117d
test: move test-vm-break-on-sigint to sequential
kvakil Aug 7, 2022
86a7fb0
test: deflake gc-http-client tests by restricting number of requests
nicksia-vgw Aug 7, 2022
70267a0
test: move tests with many workers to sequential
kvakil Aug 7, 2022
c59dc7a
meta: update AUTHORS
nodejs-github-bot Aug 7, 2022
6be7e6d
tools: update lint-md-dependencies to @rollup/[email protected]
nodejs-github-bot Aug 7, 2022
a92d90b
deps: update corepack to 0.12.2
nodejs-github-bot Aug 7, 2022
fecec4d
build: add workflow to label flaky-test platform
RafaelGSS Aug 7, 2022
873941a
tools: update eslint to 8.21.0
nodejs-github-bot Aug 8, 2022
d09bc54
deps: update undici to 5.8.1
nodejs-github-bot Aug 8, 2022
a6dccc9
esm: do not bind loader hook functions
aduh95 Aug 8, 2022
79445cb
test: update console web platform tests
anonrig Aug 2, 2022
537d52f
test: update hr-time web platform tests
anonrig Aug 2, 2022
6b84451
test: update wasm/jsapi web platform tests
anonrig Aug 2, 2022
04007f2
lib: fix diagnostics channel
theanarkh Aug 8, 2022
340ca4d
http: fix error message when specifying headerTimeout for createServer
nicksia-vgw Aug 9, 2022
818271c
deps: update undici to 5.8.2
nodejs-github-bot Aug 9, 2022
b2a15b6
test: update wpt url status
cola119 Aug 10, 2022
d57178c
events: use bitset to save memory
mabaasit Jul 6, 2022
11f74e7
test: update WPT runner
panva Aug 10, 2022
721639a
doc: fix typo in diagnostics_channel
evanlucas Aug 10, 2022
b9fd240
perf_hooks: fix gc elapsed time
theanarkh Aug 10, 2022
6bff14b
doc: update tags in adding-new-napi-api.md
legendecas Aug 10, 2022
aa7c053
net: remove unused callback
theanarkh Aug 11, 2022
126fbba
assert: add assert.Snapshot
MoLow Aug 11, 2022
4d26cb9
doc: add MoLow to collaborators
MoLow Aug 11, 2022
b1590bb
deps: upgrade npm to 8.17.0
npm-cli-bot Aug 11, 2022
0e20072
assert: add `getCalls` and `reset` to callTracker
MoLow Aug 11, 2022
beaf5f5
test: use `mustSucceed` instead of `mustCall` with `assert.ifError`
fossamagna Aug 12, 2022
f39a051
doc: improved building doc for Android
MeowShe Aug 12, 2022
ad8ef3a
crypto: fix webcrypto operation errors to be OperationError
panva Aug 12, 2022
81e1ec4
crypto: fix webcrypto generateKey() AES key length validation error
panva Aug 8, 2022
4c902be
crypto: fix webcrypto EC key namedCurve validation errors
panva Aug 8, 2022
ac2b10e
crypto: fix webcrypto deriveBits validations
panva Aug 8, 2022
07d90c8
crypto: allow zero-length secret KeyObject
panva Aug 11, 2022
1c0d66e
crypto: allow zero-length IKM in HKDF and in webcrypto PBKDF2
panva Aug 11, 2022
2ae2828
build: enable pointer authentication for branch protection on arm64
jgowdy-godaddy Aug 12, 2022
37a9d7a
errors: refactor to use optional chaining
xtx1130 Aug 3, 2022
4e1ffd9
src: fix --heapsnapshot-near-heap-limit error hint
legendecas Aug 14, 2022
2c72ded
meta: update AUTHORS
nodejs-github-bot Aug 14, 2022
9755b1f
test: mark connection leak test flaky on IBM i
richardlau Aug 14, 2022
a3cc8ce
tools: update lint-md-dependencies to [email protected]
nodejs-github-bot Aug 14, 2022
e373144
test: add filesystem check to `test-fs-stat-date.mjs`
LiviaMedeiros Aug 14, 2022
a269972
deps: update corepack to 0.12.3
nodejs-github-bot Aug 14, 2022
8216434
test,crypto: update WebCryptoAPI WPT
panva Aug 14, 2022
f5e2f6c
test: remove cjs loader from stack traces
GeoffreyBooth Aug 14, 2022
9614907
src: remove usage on ScriptCompiler::CompileFunctionInContext
legendecas Aug 10, 2022
b4224dd
test: reduce http-server-request-timeouts-mixed flakiness
nicksia-vgw Aug 8, 2022
8c1fe86
doc: fix added version for readable.closed/destroyed
MasterOdin Jul 29, 2022
c079abe
stream: improve views validation on `BYOBRequest`
daeyeon Aug 15, 2022
e8916fa
doc: add cola119 to collaborators
cola119 Aug 16, 2022
a02492f
test: move "errors" test to "parallel"
targos Aug 16, 2022
c842ab3
report: skip report if uncaught exception is handled
legendecas Aug 16, 2022
851264c
http: add max for http keepalive
theanarkh Aug 16, 2022
87f75a2
tools: update lint-md-dependencies to [email protected]
nodejs-github-bot Aug 16, 2022
2cf3ce8
trace_events: add example
theanarkh Aug 16, 2022
ecf7b07
tls: use logical OR operator
VoltrexKeyva Aug 16, 2022
36b39db
tools: update ESLint to 8.22.0
lpinca Aug 17, 2022
19557ad
dgram: add dgram send queue info
theanarkh Aug 17, 2022
2efce0f
typings: add JSDoc for `internal/validators`
anonrig Aug 17, 2022
f7be92f
meta: update `web streams` in label-pr-config
daeyeon Aug 17, 2022
7b6126a
test: update Web Streams WPT
daeyeon Aug 17, 2022
8cfc8b0
lib: refactor to avoid prototype pollution
aduh95 Aug 17, 2022
bce8041
deps: upgrade npm to 8.18.0
npm-cli-bot Aug 18, 2022
a3ac445
stream: fix `isDetachedBuffer` validations
daeyeon Aug 18, 2022
d2dce59
src: avoid copying BaseObjectPtrs in loop
tniessen Aug 18, 2022
e8441a2
doc,report: document special filenames
legendecas Aug 19, 2022
3765c63
src: extract common context embedder tag checks
legendecas Aug 17, 2022
7a56787
doc: add TypeScript execution requirements
mhdawson Jul 28, 2022
8cf6499
report: print javascript stack on fatal error
legendecas Aug 15, 2022
a2707d0
test: add coverage for invalid RSA-PSS digests
tniessen Aug 20, 2022
3dadc95
src: refactor to avoid using a moved object
tniessen Aug 20, 2022
d3f3bf6
doc: fix typo
h-a-n-a Aug 20, 2022
a933712
doc: fix optionality of callback arg of checkPrime
tniessen Aug 20, 2022
c0b160c
test_runner: fix test runner hooks failure stack
MoLow Aug 20, 2022
0e38fba
perf_hooks: add resourcetiming buffer limit
legendecas Aug 21, 2022
8977a87
meta: update AUTHORS
nodejs-github-bot Aug 21, 2022
e9d19ac
src: use imported namespaces in `node_contextify.cc`
juanarbol Aug 21, 2022
f7c1b83
tools: update lint-md-dependencies to [email protected]
nodejs-github-bot Aug 21, 2022
4ec3f67
fs: add encoding parameter to benchmarks
anonrig Aug 21, 2022
c270b9a
deps: update corepack to 0.13.0
nodejs-github-bot Aug 21, 2022
1a44fbc
lib: add diagnostics channel and perf hooks detail
danielleadams Jul 26, 2022
514e516
test: deflake test-diagnostics-channel-net
kvakil Aug 7, 2022
1b3fcf7
net: create diagnostics channels lazily
joyeecheung Aug 2, 2022
3561514
bootstrap: implement --snapshot-blob and --build-snapshot
joyeecheung May 27, 2021
597a517
bootstrap: clean up warning setup during serialization
joyeecheung Jul 20, 2022
d4189ab
test: add UMD module test with marked
joyeecheung Sep 9, 2021
40b817c
test: test snapshotting TypeScript compiler
joyeecheung Sep 27, 2021
87d7845
bootstrap: fixup Error.stackTraceLimit for user-land snapshot
joyeecheung Aug 18, 2022
ab73cc8
src: disambiguate terms used to refer to builtins and addons
joyeecheung Aug 4, 2022
c200106
2022-08-24, Version 18.8.0 (Current)
ruyadorno Aug 23, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
1 change: 1 addition & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ test/message/esm_display_syntax_error.mjs
tools/icu
tools/lint-md/lint-md.mjs
benchmark/tmp
benchmark/fixtures
doc/**/*.js
!doc/api_assets/*.js
!.eslintrc.js
3 changes: 2 additions & 1 deletion .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,8 @@

/benchmark/misc/startup.js @nodejs/startup
/src/node.cc @nodejs/startup
/src/node_native_module* @nodejs/startup
/src/node_builtins* @nodejs/startup
/src/node_snapshot* @nodejs/startup
/lib/internal/bootstrap/* @nodejs/startup
/tools/snapshot/* @nodejs/startup

Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/1-bug-report.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ body:
label: Platform
description: |
UNIX: output of `uname -a`
Windows: output of `"$([Environment]::OSVersion | ForEach-Object VersionString) $(if ([Environment]::Is64BitOperatingSystem) { "x64" } else { "x86" })"` in PowerShell console
Windows: output of `"$([Environment]::OSVersion.VersionString) $(('x86', 'x64')[[Environment]::Is64BitOperatingSystem])"` in PowerShell console
- type: input
attributes:
label: Subsystem
Expand Down
2 changes: 2 additions & 0 deletions .github/label-pr-config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ subSystemLabels:
/^lib\/worker_threads.js$/: worker
/^lib\/internal\/url\.js$/: whatwg-url
/^lib\/internal\/modules\/esm/: esm
/^lib\/internal\/webstreams/: web streams

# All other lib/ files map directly
/^lib\/_(\w+)_\w+\.js?$/: $1 # e.g. _(stream)_wrap
Expand All @@ -123,6 +124,7 @@ exlusiveLabels:
/^test\/report\//: test, report
/^test\/fixtures\/es-module/: test, esm
/^test\/es-module\//: test, esm
/^test\/fixtures\/wpt\/streams//: test, web streams

/^test\//: test

Expand Down
50 changes: 50 additions & 0 deletions .github/workflows/label-flaky-test-issue.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
name: Label Flaky Test Issues

on:
issues:
types: [opened, labeled]

jobs:
label:
if: github.event.label.name == 'flaky-test'
runs-on: ubuntu-latest
permissions:
issues: write
steps:
- name: Extract labels
id: extract-labels
env:
BODY: ${{ github.event.issue.body }}
run: |
BODY="${BODY//$'\n'/'\n'}"

declare -A platform2label

platform2label["AIX"]="aix";
platform2label["FreeBSD"]="freebsd";
platform2label["Linux ARM64"]="linux";
platform2label["Linux ARMv7"]="arm";
platform2label["Linux PPC64LE"]="ppc";
platform2label["Linux s390x"]="s390";
platform2label["Linux x64"]="linux";
platform2label["macOS ARM64"]="macos";
platform2label["macOS x64"]="macos";
platform2label["SmartOS"]="smartos";
platform2label["Windows"]="windows";

# sed is cleaning up the edges
PLATFORMS=$(echo $BODY | sed 's/^.*Platform\\n\\n//' | sed 's/\(, Other\)\?\\n\\n.*$//') 2> /dev/null
readarray -d , -t list <<< "$PLATFORMS"
labels=
for row in "${list[@]}"; do \
platform=$(echo $row | xargs); \
labels="${labels}${platform2label[$platform]},"; \
done;

echo "::set-output name=LABELS::${labels::-1}"

- name: Add labels
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
NUMBER: ${{ github.event.issue.number }}
run: gh issue edit "$NUMBER" --repo ${{ github.repository }} --add-label "${{ steps.extract-labels.outputs.LABELS }}"
1 change: 1 addition & 0 deletions .github/workflows/test-internet.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ permissions:

jobs:
test-internet:
if: github.repository == 'nodejs/node' || github.event_name != 'schedule'
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
Expand Down
5 changes: 5 additions & 0 deletions .mailmap
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,7 @@ Hannes Magnusson <[email protected]> <[email protected]>
Hassaan Pasha <[email protected]> <[email protected]>
Hendrik Schwalm <[email protected]>
Henry Chin <[email protected]>
Nick Sia <[email protected]> <[email protected]>
Herbert Vojčík <[email protected]>
Hitesh Kanwathirtha <[email protected]> <[email protected]>
Icer Liang <[email protected]> <[email protected]>
Expand Down Expand Up @@ -287,6 +288,8 @@ Ke Ding <[email protected]>
Keith M Wesolowski <[email protected]> <[email protected]>
Kelsey Breseman <[email protected]>
Kevin Millikin <[email protected]>
Keyhan Vakil <[email protected]> <[email protected]>
Keyhan Vakil <[email protected]> <[email protected]>
Khaidi Chu <[email protected]>
Khaidi Chu <[email protected]> <[email protected]>
Kimberly Wilber <[email protected]>
Expand Down Expand Up @@ -429,6 +432,8 @@ Ron Korving <[email protected]> <[email protected]>
Ruben Bridgewater <[email protected]> <[email protected]>
Ruben Bridgewater <[email protected]> <[email protected]>
Russell Dempsey <[email protected]> <[email protected]>
Ruy Adorno <[email protected]> <[email protected]>
Ruy Adorno <[email protected]> <[email protected]>
Ryan Dahl <[email protected]>
Ryan Emery <[email protected]>
Ryan Mahan <[email protected]>
Expand Down
26 changes: 23 additions & 3 deletions AUTHORS
Original file line number Diff line number Diff line change
Expand Up @@ -1048,7 +1048,7 @@ Joran Siu <[email protected]>
Vitaly Tomilov <[email protected]>
Ratikesh Misra <[email protected]>
Alex Perkins <[email protected]>
Beth Griggs <bgriggs@redhat.com>
Beth Griggs <bethanyngriggs@gmail.com>
Joe Esposito <[email protected]>
Erin Spiceland <[email protected]>
Ravindra Barthwal <[email protected]>
Expand Down Expand Up @@ -1784,7 +1784,7 @@ Christopher Sidebottom <[email protected]>
Edward Andrew Robinson <[email protected]>
Shakeel Mohamed <[email protected]>
Tobias Kieslich <[email protected]>
Ruy Adorno <ruyadorno@hotmail.com>
Ruy Adorno <ruyadorno@google.com>
Stefania Sharp <[email protected]>
Pawel Golda <[email protected]>
Steven Scott <[email protected]>
Expand Down Expand Up @@ -3457,7 +3457,7 @@ Yagiz Nizipli <[email protected]>
liuxingbaoyu <[email protected]>
Sergey Nazaryev <[email protected]>
William Marlow <[email protected]>
Keyhan Vakil <[email protected]>
Keyhan Vakil <[email protected]>
Feng Yu <[email protected]>
pupilTong <[email protected]>
rikapo <[email protected]>
Expand Down Expand Up @@ -3490,5 +3490,25 @@ John Gee <[email protected]>
Hrishikesh Kadam <[email protected]>
KrayzeeKev <[email protected]>
Airing <[email protected]>
jiahao.si <[email protected]>
Rhys <[email protected]>
Mark S. Miller <[email protected]>
Jianru Lin <[email protected]>
Lenvin Gonsalves <[email protected]>
Andreu Botella <[email protected]>
shhh7612 <[email protected]>
Dominic Saadi <[email protected]>
ywave620 <[email protected]>
NicoNekoru <[email protected]>
SADIK KUZU <[email protected]>
flakey5 <[email protected]>
Saurabh Daware <[email protected]>
BuShe <[email protected]>
Nick Sia <[email protected]>
Basit Chonka <[email protected]>
Jeremiah Gowdy <[email protected]>
Matthew Peveler <[email protected]>
Wing <[email protected]>
Hana <[email protected]>

# Generated by tools/update-authors.mjs
13 changes: 8 additions & 5 deletions BUILDING.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ file a new issue.
* [Option 1: Manual install](#option-1-manual-install)
* [Option 2: Automated install with Boxstarter](#option-2-automated-install-with-boxstarter)
* [Building Node.js](#building-nodejs-2)
* [Android/Android-based devices (e.g. Firefox OS)](#androidandroid-based-devices-eg-firefox-os)
* [Android](#android)
* [`Intl` (ECMA-402) support](#intl-ecma-402-support)
* [Build with full ICU support (all locales supported by ICU)](#build-with-full-icu-support-all-locales-supported-by-icu)
* [Unix/macOS](#unixmacos)
Expand Down Expand Up @@ -647,22 +647,25 @@ To test if Node.js was built correctly:
> Release\node -e "console.log('Hello from Node.js', process.version)"
```

### Android/Android-based devices (e.g. Firefox OS)
### Android

Android is not a supported platform. Patches to improve the Android build are
welcome. There is no testing on Android in the current continuous integration
environment. The participation of people dedicated and determined to improve
Android building, testing, and support is encouraged.

Be sure you have downloaded and extracted
[Android NDK](https://developer.android.com/tools/sdk/ndk/index.html) before in
[Android NDK](https://developer.android.com/ndk) before in
a folder. Then run:

```console
$ ./android-configure /path/to/your/android-ndk
$ make
$ source ./android-configure /path/to/your/android-ndk target_arch android_sdk_version
$ make -j4
```

The Android SDK version should be at least 24 (Android 7.0) and the target
architecture supports \[arm, arm64/aarch64, x86, x86\_64].

## `Intl` (ECMA-402) support

[Intl](https://github.com/nodejs/node/blob/HEAD/doc/api/intl.md) support is
Expand Down
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@ release.
</tr>
<tr>
<td valign="top">
<b><a href="doc/changelogs/CHANGELOG_V18.md#18.7.0">18.7.0</a></b><br/>
<b><a href="doc/changelogs/CHANGELOG_V18.md#18.8.0">18.8.0</a></b><br/>
<a href="doc/changelogs/CHANGELOG_V18.md#18.7.0">18.7.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V18.md#18.6.0">18.6.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V18.md#18.5.0">18.5.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V18.md#18.4.0">18.4.0</a><br/>
Expand Down
12 changes: 11 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -296,6 +296,8 @@ For information about the governance of the Node.js project, see
**Colin Ihrig** <<[email protected]>> (he/him)
* [codebytere](https://github.com/codebytere) -
**Shelley Vohr** <<[email protected]>> (she/her)
* [cola119](https://github.com/cola119) -
**Kohei Ueno** <<[email protected]>> (he/him)
* [danbev](https://github.com/danbev) -
**Daniel Bevenius** <<[email protected]>> (he/him)
* [danielleadams](https://github.com/danielleadams) -
Expand All @@ -310,6 +312,8 @@ For information about the governance of the Node.js project, see
**Daniele Belardi** <<[email protected]>> (he/him)
* [edsadr](https://github.com/edsadr) -
**Adrian Estrada** <<[email protected]>> (he/him)
* [erickwendel](https://github.com/erickwendel) -
**Erick Wendel** <<[email protected]>> (he/him)
* [evanlucas](https://github.com/evanlucas) -
**Evan Lucas** <<[email protected]>> (he/him)
* [fhinkel](https://github.com/fhinkel) -
Expand Down Expand Up @@ -380,6 +384,8 @@ For information about the governance of the Node.js project, see
**Milad Fa** <<[email protected]>> (he/him)
* [mildsunrise](https://github.com/mildsunrise) -
**Alba Mendez** <<[email protected]>> (she/her)
* [MoLow](https://github.com/MoLow) -
**Moshe Atlow** <<[email protected]>> (he/him)
* [mscdex](https://github.com/mscdex) -
**Brian White** <<[email protected]>>
* [MylesBorins](https://github.com/MylesBorins) -
Expand All @@ -405,7 +411,7 @@ For information about the governance of the Node.js project, see
* [ronag](https://github.com/ronag) -
**Robert Nagy** <<[email protected]>>
* [ruyadorno](https://github.com/ruyadorno) -
**Ruy Adorno** <<ruyadorno@github.com>> (he/him)
**Ruy Adorno** <<ruyadorno@google.com>> (he/him)
* [rvagg](https://github.com/rvagg) -
**Rod Vagg** <<[email protected]>>
* [ryzokuken](https://github.com/ryzokuken) -
Expand All @@ -424,6 +430,8 @@ For information about the governance of the Node.js project, see
**Stewart X Addison** <<[email protected]>> (he/him)
* [targos](https://github.com/targos) -
**Michaël Zasso** <<[email protected]>> (he/him)
* [theanarkh](https://github.com/theanarkh) -
**theanarkh** <<[email protected]>> (he/him)
* [TimothyGu](https://github.com/TimothyGu) -
**Tiancheng "Timothy" Gu** <<[email protected]>> (he/him)
* [tniessen](https://github.com/tniessen) -
Expand Down Expand Up @@ -658,6 +666,8 @@ maintaining the Node.js project.
**Himadri Ganguly** <<[email protected]>> (he/him)
* [iam-frankqiu](https://github.com/iam-frankqiu) -
**Frank Qiu** <<[email protected]>> (he/him)
* [kvakil](https://github.com/kvakil) -
**Keyhan Vakil** <<[email protected]>> (they/them)
* [marsonya](https://github.com/marsonya) -
**Akhil Marsonya** <<[email protected]>> (he/him)
* [meixg](https://github.com/meixg) -
Expand Down
8 changes: 3 additions & 5 deletions android-configure
Original file line number Diff line number Diff line change
Expand Up @@ -17,16 +17,14 @@ NDK_PATH=$1
ARCH="$2"
ANDROID_SDK_VERSION=$3

if [ $ANDROID_SDK_VERSION -lt 23 ]; then
echo "$ANDROID_SDK_VERSION should equal or later than 23(Android 6.0)"
if [ $ANDROID_SDK_VERSION -lt 24 ]; then
echo "$ANDROID_SDK_VERSION should equal or later than 24 (Android 7.0)"
fi

CC_VER="4.9"

case $ARCH in
arm)
DEST_CPU="arm"
TOOLCHAIN_NAME="armv7-linux-androideabi"
TOOLCHAIN_NAME="armv7a-linux-androideabi"
;;
x86)
DEST_CPU="ia32"
Expand Down
34 changes: 34 additions & 0 deletions benchmark/es/error-stack.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
'use strict';

const common = require('../common.js');
const modPath = require.resolve('../fixtures/simple-error-stack.js');

const bench = common.createBenchmark(main, {
method: ['without-sourcemap', 'sourcemap'],
n: [1e5],
});

function runN(n) {
delete require.cache[modPath];
const mod = require(modPath);
bench.start();
for (let i = 0; i < n; i++) {
mod.simpleErrorStack();
}
bench.end(n);
}

function main({ n, method }) {
switch (method) {
case 'without-sourcemap':
process.setSourceMapsEnabled(false);
runN(n);
break;
case 'sourcemap':
process.setSourceMapsEnabled(true);
runN(n);
break;
default:
throw new Error(`Unexpected method "${method}"`);
}
}
15 changes: 15 additions & 0 deletions benchmark/fixtures/simple-error-stack.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

17 changes: 17 additions & 0 deletions benchmark/fixtures/simple-error-stack.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
'use strict';

// Compile with `tsc --inlineSourceMap benchmark/fixtures/simple-error-stack.ts`.

const lorem = 'Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.';

function simpleErrorStack() {
try {
(lorem as any).BANG();
} catch (e) {
return e.stack;
}
}

export {
simpleErrorStack,
};
Loading