Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: upgrade llhttp to 6.0.9 #44344

Merged
merged 1 commit into from
Aug 25, 2022
Merged

deps: upgrade llhttp to 6.0.9 #44344

merged 1 commit into from
Aug 25, 2022

Conversation

ShogunPanda
Copy link
Contributor

Fixes: #43115

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Aug 22, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46150/

RafaelGSS
RafaelGSS approved these changes Aug 22, 2022
View reviewed changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

mcollina
mcollina approved these changes Aug 22, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 24, 2022
@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 25, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 25, 2022
@nodejs-github-bot nodejs-github-bot merged commit ec0d8da into nodejs:main Aug 25, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in ec0d8da

sidwebworks pushed a commit to sidwebworks/node that referenced this pull request Aug 26, 2022
@ShogunPanda @sidwebworks
deps: upgrade llhttp to 6.0.9
3ba89ea 
PR-URL: nodejs#44344
Fixes: nodejs#43115
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Sep 5, 2022
@ShogunPanda @RafaelGSS
deps: upgrade llhttp to 6.0.9
1e451dc 
PR-URL: #44344
Fixes: #43115
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
This was referenced Sep 5, 2022
Merged
Merged
climba03003
climba03003 reviewed Sep 9, 2022
View reviewed changes
deps/llhttp/CMakeLists.txt
@@ -1,21 +1,21 @@
cmake_minimum_required(VERSION 3.5.1)
cmake_policy(SET CMP0069 NEW)

project(llhttp VERSION 6.0.5)
project(llhttp VERSION )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShogunPanda
It seems like a missing version here?

@ShogunPanda
Copy link
Contributor Author

Yes, somehow I missed it.

@mhdawson Do you think we can fix this in #44136?

@mhdawson
Copy link
Member

mhdawson commented Sep 9, 2022

@ShogunPanda do you mean fix the instructions, or update the instrtuction and then fix the missing version number at the same time?

@ShogunPanda
Copy link
Contributor Author

The latter. Fix both the version and the instructions, eventually following my suggestion above.

Fyko pushed a commit to Fyko/node that referenced this pull request Sep 15, 2022
@ShogunPanda @Fyko
deps: upgrade llhttp to 6.0.9
03f045b 
PR-URL: nodejs#44344
Fixes: nodejs#43115
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
targos pushed a commit that referenced this pull request Sep 16, 2022
@ShogunPanda @targos
deps: upgrade llhttp to 6.0.9
5be2665 
PR-URL: #44344
Fixes: #43115
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@ruyadorno
Copy link
Member

Heads up @ShogunPanda this commit had landed in v16.x-staging but it ended up conflicting with 0713e21 and had to be skipped when rebasing. I would appreciate if you could follow up and make sure that everything looks fine with regards to llhttp version in the v16.x release line.

@ShogunPanda
Copy link
Contributor Author

@ruyadorno Since 16.17.1 has been released and it contains 6.0.10, I think this has been superseded. Am I wrong?

@ruyadorno
Copy link
Member

I would assume so but I believe it might need your eyes just to make sure it didn't missed anything from this update I guess.
Anyways, if that's the case and it has been successfully superseded than I believe we should add a label to this PR to avoid having this commit showing up during the update of the staging branch phase. Adding dont-land-on-v16.x should do it 😊

@ruyadorno
Copy link
Member

actually, I'll preemptively add the dont-land label 😁

@ShogunPanda
Copy link
Contributor Author

So, all files are correctly changed, except for deps/llhttp/llhttp.h and deps/llhttp/CMakeLists.txt which show the wrong version (not the 6.0.9 on this PR but the newly released 6.0.10). What shall we do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@climba03003 climba03003 climba03003 left review comments

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@trivikr trivikr trivikr approved these changes

@richardlau richardlau richardlau approved these changes

@Trott Trott Trott approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

http module accepts all http versions (e.g. HTTP/9.9) and treats/responds to them as http1
10 participants
@ShogunPanda @nodejs-github-bot @mhdawson @ruyadorno @mcollina @Trott @richardlau @trivikr @climba03003 @RafaelGSS