-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stream: fix writableStream.abort()
#44327
stream: fix writableStream.abort()
#44327
Conversation
This includes: - Fixing `writableStream.abort(reason)`. Passing the reason was missing. - Leaving a TODO to remove the internal abortReason property of WritableStreamDefaultController. Signed-off-by: Daeyeon Jeong [email protected]
/cc @nodejs/whatwg-stream |
I think this should add a test that checks that |
There is a test and this fix will get it passed. node/test/fixtures/wpt/streams/writable-streams/aborting.any.js Lines 1380 to 1391 in a99fa50
|
Why is the main branch passing all tests currently then? |
I think that's because the test was expected to fail previously on main node/test/wpt/status/streams.json Lines 110 to 114 in e5fb452
|
Understand the query. Unlike other Node.js APIs, developing Web compatible APIs is allowed to use preparing tests first and developing later approach (TDD) if there are Web Platform Tests we can rely on for basic compatibility testing. When running WPT, our WPT harness refers to a JSON status file describing tests we don't support yet. And it ignores a test result if a certain test is marked as expected to fail. This updates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Please do not use resume to re-run the tests - a proper rebase from the CI is necessary to include #44359 |
Thanks for the information. I mistook that the resume build also includes the rebase process. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Landed in 4af0a26 |
This includes: - Fixing `writableStream.abort(reason)`. Passing the reason was missing. - Leaving a TODO to remove the internal abortReason property of WritableStreamDefaultController. Signed-off-by: Daeyeon Jeong [email protected] PR-URL: nodejs#44327 Refs: https://streams.spec.whatwg.org/#writable-stream-abort Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
This includes: - Fixing `writableStream.abort(reason)`. Passing the reason was missing. - Leaving a TODO to remove the internal abortReason property of WritableStreamDefaultController. Signed-off-by: Daeyeon Jeong [email protected] PR-URL: #44327 Refs: https://streams.spec.whatwg.org/#writable-stream-abort Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
This includes: - Fixing `writableStream.abort(reason)`. Passing the reason was missing. - Leaving a TODO to remove the internal abortReason property of WritableStreamDefaultController. Signed-off-by: Daeyeon Jeong [email protected] PR-URL: #44327 Refs: https://streams.spec.whatwg.org/#writable-stream-abort Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
This is not landing cleanly in the v16.x release line; would yo mind rebasing to v16.x? |
This includes:
writableStream.abort(reason)
. Passing thereason
was missing.abortReason
property ofWritableStreamDefaultController
in a follow-up.Refs: https://streams.spec.whatwg.org/#writable-stream-abort
Signed-off-by: Daeyeon Jeong [email protected]