Grab file name from file_info for accuracy

[jsheely]

The handle->filew out of ReadDirectoryChangesW grabs the closest match to the file but does not contain the actual file name

fs.watch('*/.jsx');
ex. /path/to/file/filename.jsx will match /path/to/file/filename.js if you use handle->filew

Using file_info->FileName it will return an event for filename.jsx or one for filename.js but at least in this case you will be able to properly filter the value in node since you have the correct file name to match against.

There is probably more we can do in order to ensure that the event doesn't leave libuv if it doesn't match the watched file path but at least this way we can accurately do something about it.

[Trott]

I believe the right place to submit this PR is https://github.com/libuv/libuv.

This is a change to libuv, a Node.js dependency, but not part of Node.js core itself.

[GenuineRex]

in libuv src/win/fs-event.c ~ line 376

        if (handle->dirw ||
          _wcsnicmp(handle->filew, file_info->FileName,
            file_info->FileNameLength / sizeof(WCHAR)) == 0 ||
          _wcsnicmp(handle->short_filew, file_info->FileName,
            file_info->FileNameLength / sizeof(WCHAR)) == 0) {

seems the culprit is this _wcsnicmp function that limits out to the length of the file changed. any reason this is not just a straight string compare instead?

[ChALkeR]

/cc @saghul

[cjihrig]

Closing, as this should go in libuv first (as previously mentioned).