test: use addon.md block headings as test dir names #4412
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscdex
added
c++
|
ping @nodejs/build, @nodejs/testing any thoughts on this? |
|
LGTM but would like to have at least @jbergstroem and @Trott take a look |
|
Semi-rubber-stamp LGTM |
| if (token.type === 'heading') { | ||
| if (token.type === 'heading' && token.text) { | ||
| blockName = token.text | ||
| console.log(token) |
|
LGTM with optional bonus nit. |
rvagg
added a commit
that referenced
this pull request
Jan 14, 2016
instead of doc-* PR-URL: #4412 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Johan Bergström <[email protected]>
rvagg
force-pushed
the
name-addon.md-test-directories
branch
from
44a666b
to
3727ae0
Compare
|
landed @ 3727ae0, thanks folks |
rvagg
added a commit
that referenced
this pull request
Jan 14, 2016
instead of doc-* PR-URL: #4412 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Johan Bergström <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 28, 2016
instead of doc-* PR-URL: #4412 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Johan Bergström <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 11, 2016
instead of doc-* PR-URL: #4412 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Johan Bergström <[email protected]>
MylesBorins
pushed a commit
to MylesBorins/node
that referenced
this pull request
Feb 11, 2016
instead of doc-* PR-URL: nodejs#4412 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Johan Bergström <[email protected]>
Merged
MylesBorins
pushed a commit
to MylesBorins/node
that referenced
this pull request
Feb 15, 2016
instead of doc-* PR-URL: nodejs#4412 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Johan Bergström <[email protected]>
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
instead of doc-* PR-URL: nodejs#4412 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Johan Bergström <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from #4411 (includes the commit from there), but not urgent and not absolutely necessary. Instead of naming the directories doc-X where X is an incrementing number, name them according to the section of the doc from which they come so when debugging you have a clue what it's doing! Requires touch a lot of stuff, I hope I'm not missing anything.
/cc @nodejs/build