Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove usages of GetBackingStore in node-api #44075

Merged
merged 1 commit into from
Aug 3, 2022
Merged

src: remove usages of GetBackingStore in node-api #44075

merged 1 commit into from
Aug 3, 2022

Conversation

kvakil
Copy link
Contributor

@kvakil kvakil commented Aug 1, 2022

This removes all usages of GetBackingStore in node-api. See the linked
issue for an explanation.

Refs: #32226
Refs: #43921

@kvakil
src: remove usages of GetBackingStore in node-api
769d815 
This removes all usages of GetBackingStore in `node-api`. See the linked
issue for an explanation.

Refs: nodejs#32226
Refs: nodejs#43921
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/node-api

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. node-api Issues and PRs related to the Node-API. labels Aug 1, 2022
@kvakil kvakil mentioned this pull request Aug 1, 2022
Merged
@F3n67u F3n67u added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 1, 2022
mcollina
mcollina approved these changes Aug 1, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@RaisinTen
Copy link
Contributor

@F3n67u a Jenkins CI run is required for this PR to be marked as author ready PRs that have at least one approval, no pending requests for changes, and a CI started. (the needs-ci PRs that need a full CI run. label denotes that). I'm starting one for this PR, could you take care of the other ones where you applied the label? Thanks!

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45761/

@F3n67u
Copy link
Member

F3n67u commented Aug 1, 2022

@F3n67u a Jenkins CI run is required for this PR to be marked as author ready PRs that have at least one approval, no pending requests for changes, and a CI started. (the needs-ci PRs that need a full CI run. label denotes that). I'm starting one for this PR, could you take care of the other ones where you applied the label? Thanks!

Done. Thanks for your friendly reminder.

@kvakil kvakil removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 1, 2022
@kvakil
Copy link
Contributor Author

kvakil commented Aug 1, 2022

(Jenkins seems to have flaked with java.nio.channels.ClosedChannelException. I'm retrying the build.)

@kvakil kvakil added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 1, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 1, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45776/

@github-actions github-actions bot mentioned this pull request Aug 2, 2022
Open
11 tasks
@kvakil kvakil added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 2, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 2, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45787/

@kvakil kvakil added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 2, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 2, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45792/

@kvakil kvakil added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 2, 2022
@kvakil kvakil self-assigned this Aug 2, 2022
@github-actions github-actions bot mentioned this pull request Aug 3, 2022
Open
15 tasks
@kvakil kvakil added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 3, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 3, 2022
@nodejs-github-bot nodejs-github-bot merged commit 4dedd81 into nodejs:main Aug 3, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 4dedd81

This was referenced Aug 5, 2022
Open
Open
danielleadams pushed a commit that referenced this pull request Aug 16, 2022
@kvakil @danielleadams
src: remove usages of GetBackingStore in node-api
8a79636 
This removes all usages of GetBackingStore in `node-api`. See the linked
issue for an explanation.

Refs: #32226
Refs: #43921
PR-URL: #44075
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Feng Yu <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@danielleadams danielleadams mentioned this pull request Aug 16, 2022
Closed
ruyadorno pushed a commit that referenced this pull request Aug 23, 2022
@kvakil @ruyadorno
src: remove usages of GetBackingStore in node-api
8e1b7e2 
This removes all usages of GetBackingStore in `node-api`. See the linked
issue for an explanation.

Refs: #32226
Refs: #43921
PR-URL: #44075
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Feng Yu <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Aug 23, 2022
Merged
Fyko pushed a commit to Fyko/node that referenced this pull request Sep 15, 2022
@kvakil @Fyko
src: remove usages of GetBackingStore in node-api
3818004 
This removes all usages of GetBackingStore in `node-api`. See the linked
issue for an explanation.

Refs: nodejs#32226
Refs: nodejs#43921
PR-URL: nodejs#44075
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Feng Yu <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@addaleax addaleax addaleax approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@legendecas legendecas legendecas approved these changes

@F3n67u F3n67u F3n67u approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

Assignees

@kvakil kvakil

Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. node-api Issues and PRs related to the Node-API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@kvakil @nodejs-github-bot @RaisinTen @F3n67u @mcollina @addaleax @gengjiawen @legendecas @targos