http: check if socket is null before destroy
#43796
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
http
F3n67u
force-pushed
the
closeIdleConnections
branch
from
fd4afb7 to
d76a3eb
Compare
F3n67u
changed the title
socket if is null before destory
F3n67u
changed the title
socket if is null before destorysocket is null before destory
F3n67u
force-pushed
the
closeIdleConnections
branch
from
d76a3eb to
b17a007
Compare
|
s/destory/destroy/ in commit message |
BethGriggs
approved these changes
Jul 12, 2022
F3n67u
force-pushed
the
closeIdleConnections
branch
from
b17a007 to
6f22fde
Compare
Fixed. Thank you. |
github-actions
bot
removed
the
request-ci
mscdex
changed the title
socket is null before destorysocket is null before destroy
lpinca
reviewed
Jul 12, 2022
| @@ -487,15 +487,15 @@ Server.prototype.closeAllConnections = function() { | |||
| const connections = this[kConnections].all(); | |||
|
|
|||
| for (let i = 0, l = connections.length; i < l; i++) { | |||
| connections[i].socket.destroy(); | |||
| connections[i].socket?.destroy(); | |||
There was a problem hiding this comment.
Can you explain how/when the socket is nulled?
There was a problem hiding this comment.
I think it's related to the flaky GC test I'm investigating (sorry, don't have a laptop to link stuff at the moment).
I noticed that the test instrumenting was setting a object to null at the end but I could never finish the investigation (on my list for Friday).
This was referenced Jul 13, 2022
RafaelGSS
approved these changes
Jul 15, 2022
|
I think this is superseded by #43949. I'm adding the blocked label to prevent this from landing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #43795