Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: work scheduled in process.nextTick can keep the event loop alive #43787

Merged
merged 4 commits into from
Jul 24, 2022
Merged

test: work scheduled in process.nextTick can keep the event loop alive #43787

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6bc38d8
test: work scheduled in process.nextTick can keep the event loop alive
andreubotella Jul 11, 2022
60bdf18
Update test/parallel/test-process-beforeexit.js
andreubotella Jul 12, 2022
a38e02b
Review suggestions
andreubotella Jul 12, 2022
f8e582e
Merge branch 'main' into test-nexttick-beforeexit
andreubotella Jul 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions test/parallel/test-process-beforeexit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,13 +59,22 @@ function tryRepeatedTimer() {
if (++n < N)
setTimeout(repeatedTimer, 1);
else // n == N
process.once('beforeExit', common.mustCall(tryNextTick));
process.once('beforeExit', common.mustCall(tryNextTick1));
andreubotella marked this conversation as resolved.
Show resolved Hide resolved
}, N);
setTimeout(repeatedTimer, 1);
}

// Test if the callback of `process.nextTick` can be invoked.
function tryNextTick() {
function tryNextTick1() {
andreubotella marked this conversation as resolved.
Show resolved Hide resolved
process.nextTick(common.mustCall(function() {
setImmediate(common.mustCall(() => {
process.once('beforeExit', common.mustCall(tryNextTick2));
}));
}));
}

// Test that `process.nextTick` won't keep the event loop running by itself.
function tryNextTick2() {
andreubotella marked this conversation as resolved.
Show resolved Hide resolved
process.nextTick(common.mustCall(function() {
process.once('beforeExit', common.mustNotCall());
}));
Expand Down