Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: deduplicate SetALPN implementations #43756

Merged
merged 1 commit into from
Jul 14, 2022
Merged

src: deduplicate SetALPN implementations #43756

merged 1 commit into from
Jul 14, 2022

Commits on Jul 10, 2022

  1. src: deduplicate SetALPN implementations 

    Instead of accepting either a std::string or a mysterious Local<Value>,
accept any std::string_view, which can trivially be constructed from
both strings and ArrayBufferViews.

This also removes the need to check IsArrayBufferView() inside of
SetALPN, which was dead code anyway.
    @tniessen
    tniessen committed Jul 10, 2022
    Configuration menu
    Copy the full SHA
    c393766 View commit details
    Browse the repository at this point in the history