doc: improvements to buffer.markdown copy #4370
Conversation
jasnell
added
buffer
|
A question from #4341 — is |
|
Appears to just be missing. I can add it to this.
|
|
@ChALkeR ... example added! |
|
@trevnorris ... would appreciate a review on this. Thanks! |
jasnell
force-pushed
the
doc-buffer-improvements
branch
from
c39b1cc
to
d5ba049
Compare
|
Finished first round of reviews. Great changes in here. |
jasnell
force-pushed
the
doc-buffer-improvements
branch
from
07c9065
to
01d4304
Compare
|
Commits squashed ... |
|
Heh after squashing, the diff isn't very conducive to review on GitHub. |
|
Ugh. Silly github. Yeah there are quite a few changes there.
|
|
Since I can't do it inline:
This is incorrect. A user can check max Other than that, LGTM. |
|
@trevnorris ... ok, addressed that nit. |
|
LGTM |
General improvements to buffer.markdown including new examples, a few fixes to existing examples, consistent formatting and others
jasnell
force-pushed
the
doc-buffer-improvements
branch
from
1773317
to
8f8bc57
Compare
General improvements to buffer.markdown including new examples, a few fixes to existing examples, consistent formatting and others PR-URL: #4370 Reviewed-By: Trevor Norris <[email protected]>
|
Landed in 67b109a |
|
@jasnell this is not merging cleanly at all on lts.. can you handle this one? |
General improvements to buffer.markdown including new examples, a few fixes to existing examples, consistent formatting and others PR-URL: nodejs#4370 Reviewed-By: Trevor Norris <[email protected]>
|
ping @jasnell |
|
when this lands in LTS it must come with #4537 |
General improvements to buffer.markdown including new examples, a few fixes to existing examples, consistent formatting and others PR-URL: nodejs#4370 Reviewed-By: Trevor Norris <[email protected]>
General improvements to buffer.markdown including new examples, a few fixes to existing examples, consistent formatting and others PR-URL: #4370 Reviewed-By: Trevor Norris <[email protected]>
General improvements to buffer.markdown including new examples, a few fixes to existing examples, consistent formatting and others PR-URL: #4370 Reviewed-By: Trevor Norris <[email protected]>
General improvements to buffer.markdown including new examples, a few fixes to existing examples, consistent formatting and others PR-URL: #4370 Reviewed-By: Trevor Norris <[email protected]>
General improvements to buffer.markdown including new examples, a few fixes to existing examples, consistent formatting and others PR-URL: nodejs#4370 Reviewed-By: Trevor Norris <[email protected]>
General improvements to buffer.markdown including new examples,
a few fixes to existing examples, consistent formatting and
others