Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cluster: fix fd leak #43650

Merged
merged 1 commit into from
Jul 11, 2022
Merged

cluster: fix fd leak #43650

merged 1 commit into from
Jul 11, 2022

Conversation

theanarkh
Copy link
Contributor

@theanarkh theanarkh commented Jul 1, 2022 •
edited
Loading

The worker should close the handle when the connections is not accepted.
cc @cjihrig

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Affected subsystem: cluster

@nodejs-github-bot nodejs-github-bot added cluster Issues and PRs related to the cluster subsystem. needs-ci PRs that need a full CI run. labels Jul 1, 2022
@F3n67u F3n67u added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 2, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 2, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45047/

@F3n67u F3n67u mentioned this pull request Jul 3, 2022
Open
@github-actions github-actions bot mentioned this pull request Jul 4, 2022
Open
23 tasks
@github-actions github-actions bot mentioned this pull request Jul 8, 2022
Open
16 tasks
@theanarkh
Copy link
Contributor Author

@mcollina @ShogunPanda Hi ! can you help review this PR ? Thanks !

ShogunPanda
ShogunPanda approved these changes Jul 8, 2022
View reviewed changes
Copy link
Contributor

@ShogunPanda ShogunPanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45177/

@github-actions github-actions bot mentioned this pull request Jul 9, 2022
Open
21 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45201/

@github-actions github-actions bot mentioned this pull request Jul 10, 2022
Open
20 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45284/

mcollina
mcollina approved these changes Jul 11, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina added commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. labels Jul 11, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 11, 2022
@nodejs-github-bot nodejs-github-bot merged commit b532dca into nodejs:main Jul 11, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in b532dca

targos pushed a commit that referenced this pull request Jul 12, 2022
@theanarkh @targos
cluster: fix fd leak
5d8ee51 
PR-URL: #43650
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@targos targos mentioned this pull request Jul 12, 2022
Merged
targos pushed a commit that referenced this pull request Jul 20, 2022
@theanarkh @targos
cluster: fix fd leak
1e436eb 
PR-URL: #43650
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
@theanarkh @targos
cluster: fix fd leak
97f4cc7 
PR-URL: #43650
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@targos targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@theanarkh @guangwong
cluster: fix fd leak
1d355bd 
PR-URL: nodejs/node#43650
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@ShogunPanda ShogunPanda ShogunPanda approved these changes

Assignees
No one assigned
Labels
cluster Issues and PRs related to the cluster subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@theanarkh @nodejs-github-bot @mcollina @ShogunPanda @F3n67u