src: fix compiler warning in src/heap_utils.cc #43579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: nodejs#43577 Signed-off-by: Darshan Sen <[email protected]>
nodejs-github-bot
added
c++
This comment was marked as outdated.
This comment was marked as outdated.
tniessen
approved these changes
Jun 26, 2022
RaisinTen
added
the
author ready
addaleax
approved these changes
Jun 26, 2022
targos
approved these changes
Jun 26, 2022
This comment was marked as outdated.
This comment was marked as outdated.
VoltrexKeyva
approved these changes
Jun 26, 2022
This comment was marked as outdated.
This comment was marked as outdated.
33 tasks
cjihrig
approved these changes
Jun 27, 2022
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
approved these changes
Jun 27, 2022
|
Fast-track has been requested by @jasnell. Please 👍 to approve. |
32 tasks
23 tasks
RaisinTen
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 49a5e81 |
mabaasit
pushed a commit
to mabaasit/node
that referenced
this pull request
Jul 6, 2022
Fixes: nodejs#43577 Signed-off-by: Darshan Sen <[email protected]> PR-URL: nodejs#43579 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
Fixes: #43577 Signed-off-by: Darshan Sen <[email protected]> PR-URL: #43579 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #43577
Signed-off-by: Darshan Sen [email protected]